fix #606, allow specifying the summary file extension

fix #606, allow specifying the summary file extension

R=paulberry@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/108f2a2a03b1926e640013f3244df625b42ec380

[Jennifer Messerly, 2016-07-22 17:54:27]

jmesserly@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2016-07-22 18:27:55]

lgtm

https://codereview.chromium.org/2176763002/diff/1/lib/src/compiler/command.dart
File lib/src/compiler/command.dart (right):

https://codereview.chromium.org/2176763002/diff/1/lib/src/compiler/command.da...
lib/src/compiler/command.dart:103: summaryPath = summaryPath.substring(0,
summaryPath.length - ext.length);
A bit confusing, since this is no longer the summary path at this point.

Consider changing to:

var buildUnitPath = summaryPath.substring(...);
return path.relative(buildUnitPath, from: moduleRoot);

[Jennifer Messerly, 2016-07-22 18:39:32]

Description was changed from

==========
fix #606, allow specifying the summary file extension
==========

to

==========
fix #606, allow specifying the summary file extension

R=paulberry@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/108f2a2a03b1926e640013f3244d...
==========

[Jennifer Messerly, 2016-07-22 18:39:33]

Committed patchset #1 (id:1) manually as
108f2a2a03b1926e640013f3244df625b42ec380 (presubmit successful).

[Jennifer Messerly, 2016-07-22 18:39:45]

https://codereview.chromium.org/2176763002/diff/1/lib/src/compiler/command.dart
File lib/src/compiler/command.dart (right):

https://codereview.chromium.org/2176763002/diff/1/lib/src/compiler/command.da...
lib/src/compiler/command.dart:103: summaryPath = summaryPath.substring(0,
summaryPath.length - ext.length);
On 2016/07/22 18:27:55, Paul Berry wrote:
> A bit confusing, since this is no longer the summary path at this point.
> 
> Consider changing to:
> 
> var buildUnitPath = summaryPath.substring(...);
> return path.relative(buildUnitPath, from: moduleRoot);

Great suggestion! Done.