Issue 2176733002: limit number of searched roots

Issue 2176733002: limit number of searched roots (Closed)

Created:
4 years, 5 months ago by caryclark

Modified:
4 years, 5 months ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

limit number of searched roots Extreme numbers can generate more than three found cubic roots when the roots are found through a binary search. Fail in this case. TBR=reed@google.com BUG=630649 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2176733002 Committed: https://skia.googlesource.com/skia/+/8a8accbcd1958c1646246b9b994fb47a3b5a6021

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -2 lines)			Patch
	M	src/pathops/SkPathOpsCubic.cpp	View		2 chunks	+4 lines, -0 lines	0 comments	Download
	M	tests/PathOpsOpTest.cpp	View		1 chunk	+53 lines, -2 lines	0 comments	Download

Total messages: 5 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176733002/1

4 years, 5 months ago (2016-07-22 17:30:22 UTC) #3

commit-bot: I haz the power

4 years, 5 months ago (2016-07-22 17:56:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8a8accbcd1958c1646246b9b994fb47a3b5a6021