Issue a strong mode warning for type inference that is unsafe with AST-based summaries.

Issue a strong mode warning for type inference that is unsafe with AST-based summaries.

See #26947 for details.

R=leafp@google.com

Committed: https://github.com/dart-lang/sdk/commit/eb7f2d6fcc2a38ecd65a5862c7daf711696ac83c

[Paul Berry, 2016-07-22 22:13:09]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com, leafp@google.com

[Leaf, 2016-07-22 23:34:41]

lgtm

https://codereview.chromium.org/2176693003/diff/1/pkg/analyzer/lib/src/task/s...
File pkg/analyzer/lib/src/task/strong/checker.dart (right):

https://codereview.chromium.org/2176693003/diff/1/pkg/analyzer/lib/src/task/s...
pkg/analyzer/lib/src/task/strong/checker.dart:745: if (ancestor is
VariableDeclaration) {
Might be a bit clearer just to make this part of the while loop test (ancestor
!= null && ancestor is! VariableDeclaration)?  Once less control flow path to
follow through the loop

https://codereview.chromium.org/2176693003/diff/1/pkg/analyzer/lib/src/task/s...
pkg/analyzer/lib/src/task/strong/checker.dart:749: if (ancestor is
InstanceCreationExpression) {
Presumably this same logic could be applied to List and Map literals, and to
generic method invocations.  Is it worth doing so?

[Paul Berry, 2016-07-23 16:18:18]

https://codereview.chromium.org/2176693003/diff/1/pkg/analyzer/lib/src/task/s...
File pkg/analyzer/lib/src/task/strong/checker.dart (right):

https://codereview.chromium.org/2176693003/diff/1/pkg/analyzer/lib/src/task/s...
pkg/analyzer/lib/src/task/strong/checker.dart:745: if (ancestor is
VariableDeclaration) {
On 2016/07/22 23:34:41, Leaf wrote:
> Might be a bit clearer just to make this part of the while loop test (ancestor
> != null && ancestor is! VariableDeclaration)?  Once less control flow path to
> follow through the loop

Done.

https://codereview.chromium.org/2176693003/diff/1/pkg/analyzer/lib/src/task/s...
pkg/analyzer/lib/src/task/strong/checker.dart:749: if (ancestor is
InstanceCreationExpression) {
On 2016/07/22 23:34:41, Leaf wrote:
> Presumably this same logic could be applied to List and Map literals, and to
> generic method invocations.  Is it worth doing so?

Done.  PTAL.

[Leaf, 2016-07-25 19:51:29]

lgtm

https://codereview.chromium.org/2176693003/diff/20001/pkg/analyzer/test/src/t...
File pkg/analyzer/test/src/task/strong/inferred_type_test.dart (right):

https://codereview.chromium.org/2176693003/diff/20001/pkg/analyzer/test/src/t...
pkg/analyzer/test/src/task/strong/inferred_type_test.dart:3862: //
TODO(paulberry): why is the call to the closure considered a
applying a function with arguments of type dynamic is a dynamic invoke in DDC
because of our "fuzzy arrows" feature.  There are exceptions for statically
known functions, and this case should be (but clearly isn't yet) handled.

https://codereview.chromium.org/2176693003/diff/20001/pkg/analyzer/test/src/t...
pkg/analyzer/test/src/task/strong/inferred_type_test.dart:3937: //
TODO(paulberry): for some reason (f/*<dynamic>) is nort properly
https://github.com/dart-lang/sdk/issues/25824

[Paul Berry, 2016-07-25 20:18:19]

Description was changed from

==========
Issue a strong mode warning for type inference that is unsafe with AST-based
summaries.

See #26947 for details.
==========

to

==========
Issue a strong mode warning for type inference that is unsafe with AST-based
summaries.

See #26947 for details.

R=leafp@google.com

Committed:
https://github.com/dart-lang/sdk/commit/eb7f2d6fcc2a38ecd65a5862c7daf711696ac83c
==========

[Paul Berry, 2016-07-25 20:18:21]

Committed patchset #2 (id:20001) manually as
eb7f2d6fcc2a38ecd65a5862c7daf711696ac83c (presubmit successful).

[Brian Wilkerson, 2016-07-27 14:09:55]

lgtm