Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden

Issue 2176653003: Wrap ClassLiterals in DoExpressions instead of giving them BlockScopes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: address comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/parsing/parser.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden b/test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden
index 63a854a639b75077a67f8eea53a5fc45ee22c22a..1f184253f45878742224149343bbf31a921e1963 100644
--- a/test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden
+++ b/test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden
@@ -14,39 +14,40 @@ snippet: "
speak() { console.log(this.name + ' is speaking.'); }
}
"
-frame size: 9
+frame size: 10
parameter count: 1
-bytecode array length: 72
+bytecode array length: 74
bytecodes: [
B(LdaTheHole),
- B(Star), R(1),
+ B(Star), R(2),
/* 30 E> */ B(StackCheck),
B(LdaTheHole),
B(Star), R(0),
- B(LdaTheHole),
- B(Star), R(2),
- B(CreateClosure), U8(0), U8(2),
+ /* 34 S> */ B(LdaTheHole),
B(Star), R(3),
- B(LdaSmi), U8(34),
+ B(CreateClosure), U8(0), U8(2),
B(Star), R(4),
- B(Wide), B(LdaSmi), U16(148),
+ B(LdaSmi), U8(34),
B(Star), R(5),
- B(CallRuntime), U16(Runtime::kDefineClass), R(2), U8(4),
- B(Star), R(2),
- B(LdrNamedProperty), R(2), U8(1), U8(1), R(3),
+ B(Wide), B(LdaSmi), U16(148),
+ B(Star), R(6),
+ B(CallRuntime), U16(Runtime::kDefineClass), R(3), U8(4),
+ B(Star), R(3),
+ B(LdrNamedProperty), R(3), U8(1), U8(1), R(4),
B(LdaConstant), U8(2),
- B(Star), R(5),
- B(CreateClosure), U8(3), U8(2),
B(Star), R(6),
- B(LdaSmi), U8(2),
+ B(CreateClosure), U8(3), U8(2),
B(Star), R(7),
- B(LdaZero),
+ B(LdaSmi), U8(2),
B(Star), R(8),
- B(Mov), R(3), R(4),
- B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(4), U8(5),
- B(CallRuntime), U16(Runtime::kToFastProperties), R(2), U8(1),
+ B(LdaZero),
+ B(Star), R(9),
+ B(Mov), R(4), R(5),
+ B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(5), U8(5),
+ B(CallRuntime), U16(Runtime::kToFastProperties), R(3), U8(1),
B(Star), R(0),
B(Star), R(1),
+ B(Star), R(2),
B(LdaUndefined),
/* 149 S> */ B(Return),
]
@@ -66,39 +67,40 @@ snippet: "
speak() { console.log(this.name + ' is speaking.'); }
}
"
-frame size: 9
+frame size: 10
parameter count: 1
-bytecode array length: 72
+bytecode array length: 74
bytecodes: [
B(LdaTheHole),
- B(Star), R(1),
+ B(Star), R(2),
/* 30 E> */ B(StackCheck),
B(LdaTheHole),
B(Star), R(0),
- B(LdaTheHole),
- B(Star), R(2),
- B(CreateClosure), U8(0), U8(2),
+ /* 34 S> */ B(LdaTheHole),
B(Star), R(3),
- B(LdaSmi), U8(34),
+ B(CreateClosure), U8(0), U8(2),
B(Star), R(4),
- B(Wide), B(LdaSmi), U16(148),
+ B(LdaSmi), U8(34),
B(Star), R(5),
- B(CallRuntime), U16(Runtime::kDefineClass), R(2), U8(4),
- B(Star), R(2),
- B(LdrNamedProperty), R(2), U8(1), U8(1), R(3),
+ B(Wide), B(LdaSmi), U16(148),
+ B(Star), R(6),
+ B(CallRuntime), U16(Runtime::kDefineClass), R(3), U8(4),
+ B(Star), R(3),
+ B(LdrNamedProperty), R(3), U8(1), U8(1), R(4),
B(LdaConstant), U8(2),
- B(Star), R(5),
- B(CreateClosure), U8(3), U8(2),
B(Star), R(6),
- B(LdaSmi), U8(2),
+ B(CreateClosure), U8(3), U8(2),
B(Star), R(7),
- B(LdaZero),
+ B(LdaSmi), U8(2),
B(Star), R(8),
- B(Mov), R(3), R(4),
- B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(4), U8(5),
- B(CallRuntime), U16(Runtime::kToFastProperties), R(2), U8(1),
+ B(LdaZero),
+ B(Star), R(9),
+ B(Mov), R(4), R(5),
+ B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(5), U8(5),
+ B(CallRuntime), U16(Runtime::kToFastProperties), R(3), U8(1),
B(Star), R(0),
B(Star), R(1),
+ B(Star), R(2),
B(LdaUndefined),
/* 149 S> */ B(Return),
]
@@ -120,14 +122,14 @@ snippet: "
static [n1]() { return n1; }
}
"
-frame size: 10
+frame size: 11
parameter count: 1
-bytecode array length: 124
+bytecode array length: 126
bytecodes: [
B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), U8(1),
- B(PushContext), R(2),
+ B(PushContext), R(3),
B(LdaTheHole),
- B(Star), R(1),
+ B(Star), R(2),
/* 30 E> */ B(StackCheck),
/* 43 S> */ B(LdaConstant), U8(0),
/* 43 E> */ B(StaContextSlot), R(context), U8(4),
@@ -135,42 +137,43 @@ bytecodes: [
/* 57 E> */ B(StaContextSlot), R(context), U8(5),
B(LdaTheHole),
B(Star), R(0),
- B(LdaTheHole),
- B(Star), R(3),
- B(CreateClosure), U8(2), U8(2),
+ /* 62 S> */ B(LdaTheHole),
B(Star), R(4),
- B(LdaSmi), U8(62),
+ B(CreateClosure), U8(2), U8(2),
B(Star), R(5),
- B(Wide), B(LdaSmi), U16(128),
+ B(LdaSmi), U8(62),
B(Star), R(6),
- B(CallRuntime), U16(Runtime::kDefineClass), R(3), U8(4),
- B(Star), R(3),
- B(LdrNamedProperty), R(3), U8(3), U8(1), R(4),
+ B(Wide), B(LdaSmi), U16(128),
+ B(Star), R(7),
+ B(CallRuntime), U16(Runtime::kDefineClass), R(4), U8(4),
+ B(Star), R(4),
+ B(LdrNamedProperty), R(4), U8(3), U8(1), R(5),
/* 75 E> */ B(LdaContextSlot), R(context), U8(4),
- B(ToName), R(6),
+ B(ToName), R(7),
B(CreateClosure), U8(4), U8(2),
- B(Star), R(7),
- B(LdaSmi), U8(2),
B(Star), R(8),
- B(LdaSmi), U8(1),
+ B(LdaSmi), U8(2),
B(Star), R(9),
- B(Mov), R(4), R(5),
- B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(5), U8(5),
+ B(LdaSmi), U8(1),
+ B(Star), R(10),
+ B(Mov), R(5), R(6),
+ B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(6), U8(5),
/* 106 E> */ B(LdaContextSlot), R(context), U8(5),
- B(ToName), R(6),
+ B(ToName), R(7),
B(LdaConstant), U8(3),
- B(TestEqualStrict), R(6),
- B(Mov), R(3), R(5),
+ B(TestEqualStrict), R(7),
+ B(Mov), R(4), R(6),
B(JumpIfToBooleanFalse), U8(7),
B(CallRuntime), U16(Runtime::kThrowStaticPrototypeError), R(0), U8(0),
B(CreateClosure), U8(5), U8(2),
- B(Star), R(7),
+ B(Star), R(8),
B(LdaSmi), U8(1),
- B(Star), R(9),
- B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(5), U8(5),
- B(CallRuntime), U16(Runtime::kToFastProperties), R(3), U8(1),
+ B(Star), R(10),
+ B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(6), U8(5),
+ B(CallRuntime), U16(Runtime::kToFastProperties), R(4), U8(1),
B(Star), R(0),
B(Star), R(1),
+ B(Star), R(2),
B(LdaUndefined),
/* 129 S> */ B(Return),
]
@@ -191,39 +194,40 @@ snippet: "
class C { constructor() { count++; }}
return new C();
"
-frame size: 7
+frame size: 8
parameter count: 1
-bytecode array length: 73
+bytecode array length: 75
bytecodes: [
B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), U8(1),
- B(PushContext), R(2),
+ B(PushContext), R(3),
B(LdaTheHole),
- B(Star), R(1),
+ B(Star), R(2),
/* 30 E> */ B(StackCheck),
/* 46 S> */ B(LdaZero),
/* 46 E> */ B(StaContextSlot), R(context), U8(4),
B(LdaTheHole),
B(Star), R(0),
- B(LdaTheHole),
- B(Star), R(3),
- B(CreateClosure), U8(0), U8(2),
+ /* 49 S> */ B(LdaTheHole),
B(Star), R(4),
- B(LdaSmi), U8(49),
+ B(CreateClosure), U8(0), U8(2),
B(Star), R(5),
- B(LdaSmi), U8(86),
+ B(LdaSmi), U8(49),
B(Star), R(6),
- B(CallRuntime), U16(Runtime::kDefineClass), R(3), U8(4),
- B(Star), R(3),
- B(LdrNamedProperty), R(3), U8(1), U8(1), R(4),
- B(CallRuntime), U16(Runtime::kToFastProperties), R(3), U8(1),
+ B(LdaSmi), U8(86),
+ B(Star), R(7),
+ B(CallRuntime), U16(Runtime::kDefineClass), R(4), U8(4),
+ B(Star), R(4),
+ B(LdrNamedProperty), R(4), U8(1), U8(1), R(5),
+ B(CallRuntime), U16(Runtime::kToFastProperties), R(4), U8(1),
B(Star), R(0),
B(Star), R(1),
+ B(Star), R(2),
/* 87 S> */ B(JumpIfNotHole), U8(11),
B(LdaConstant), U8(2),
+ B(Star), R(5),
+ B(CallRuntime), U16(Runtime::kThrowReferenceError), R(5), U8(1),
B(Star), R(4),
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(4), U8(1),
- B(Star), R(3),
- /* 94 E> */ B(New), R(3), R(0), U8(0),
+ /* 94 E> */ B(New), R(4), R(0), U8(0),
/* 103 S> */ B(Return),
]
constant pool: [
« no previous file with comments | « src/parsing/parser.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698