src/compiler/ast-graph-builder.h - Issue 2176653003: Wrap ClassLiterals in DoExpressions instead of giving them BlockScopes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/ast-graph-builder.h

Issue 2176653003: Wrap ClassLiterals in DoExpressions instead of giving them BlockScopes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: address comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/ast-graph-builder.h

diff --git a/src/compiler/ast-graph-builder.h b/src/compiler/ast-graph-builder.h

index 84f3fb684763f12a0dbb827dc9abf7744fa89b9b..28e5578c3308ee62dd913ebfdce8cec7ca038c42 100644

--- a/src/compiler/ast-graph-builder.h

+++ b/src/compiler/ast-graph-builder.h

@@ -457,9 +457,6 @@ class AstGraphBuilder : public AstVisitor<AstGraphBuilder> {

void VisitObjectLiteralAccessor(Node* home_object,

ObjectLiteralProperty* property);

- // Dispatched from VisitClassLiteral.

- void VisitClassLiteralContents(ClassLiteral* expr);

DEFINE_AST_VISITOR_SUBCLASS_MEMBERS();

DISALLOW_COPY_AND_ASSIGN(AstGraphBuilder);

};

« no previous file with comments | « src/ast/ast.cc ('k') | src/compiler/ast-graph-builder.cc » ('j') | no next file with comments »