Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Unified Diff: src/full-codegen/full-codegen.cc

Issue 2176653003: Wrap ClassLiterals in DoExpressions instead of giving them BlockScopes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/full-codegen/full-codegen.cc
diff --git a/src/full-codegen/full-codegen.cc b/src/full-codegen/full-codegen.cc
index 1be537f4befa856eb51bf876e969a5d728e2b887..a931810a2e15e07ba62958eee45400f280ba7df2 100644
--- a/src/full-codegen/full-codegen.cc
+++ b/src/full-codegen/full-codegen.cc
@@ -1447,10 +1447,6 @@ void FullCodeGenerator::VisitClassLiteral(ClassLiteral* lit) {
Comment cmnt(masm_, "[ ClassLiteral");
{
Michael Starzinger 2016/07/25 14:49:54 nit: This block looks like it was only introduced
bakkot 2016/07/25 18:52:04 Done.
- NestedClassLiteral nested_class_literal(this, lit);
- EnterBlockScopeIfNeeded block_scope_state(
- this, lit->scope(), lit->EntryId(), lit->DeclsId(), lit->ExitId());
-
if (lit->extends() != NULL) {
VisitForStackValue(lit->extends());
} else {

Powered by Google App Engine
This is Rietveld 408576698