Remove platform/text/ParserUtilities.h

Reland of Remove platform/text/ParserUtilities.h

platform/ParsingUtilities.h caters to the same needs, so transition
users of skipString(...) to skipToken(...) and remove
platform/text/ParserUtilities.h.

Committed: https://crrev.com/913442c00dc54f837e9d6b8f0c49d625f91af6b1
Cr-Commit-Position: refs/heads/master@{#407259}

[fs, 2016-07-22 13:30:28]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 13:30:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 13:33:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 13:33:24]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[fs, 2016-07-22 15:20:27]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 15:20:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2016-07-22 16:08:41]

fs@opera.com changed reviewers:
+ pdr@chromium.org, schenney@chromium.org

[Stephen Chennney, 2016-07-22 16:36:10]

Wow. The transformation is amazing. LGTM.

[commit-bot: I haz the power, 2016-07-22 16:42:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 16:42:09]

Dry run: This issue passed the CQ dry run.

[fs, 2016-07-22 17:15:03]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-07-22 17:15:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 17:18:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-22 17:21:09]

Description was changed from

==========
Remove platform/text/ParserUtilities.h

platform/ParsingUtilities.h caters to the same needs, so transition
users of skipString(...) to skipToken(...) and remove
platform/text/ParserUtilities.h.
==========

to

==========
Remove platform/text/ParserUtilities.h

platform/ParsingUtilities.h caters to the same needs, so transition
users of skipString(...) to skipToken(...) and remove
platform/text/ParserUtilities.h.

Committed: https://crrev.com/39cc523b5dbf9d2ddad9483cb27fab8b97e53ec1
Cr-Commit-Position: refs/heads/master@{#407187}
==========

[commit-bot: I haz the power, 2016-07-22 17:21:10]

Patchset 2 (id:??) landed as
https://crrev.com/39cc523b5dbf9d2ddad9483cb27fab8b97e53ec1
Cr-Commit-Position: refs/heads/master@{#407187}

[Mark P, 2016-07-22 18:10:38]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2179563002/ by mpearson@chromium.org.

The reason for reverting is: Likely cause of failures:

---
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/6...

unexpected_failures:
fast/forms/color/color-suggestion-picker-appearance-zoom125.html
fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html
fast/forms/color/color-suggestion-picker-appearance-zoom200.html

all with the message
image diff
---

---
also bot: 
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28...

http/tests/images/restyle-decode-error.html

in which case there is a renderer crash in this test
---

also some other bots for tests
fast/forms/color/color-suggestion-picker-appearance.html
fast/forms/color/color-suggestion-picker-one-row-appearance.html
fast/forms/color/color-suggestion-picker-two-row-appearance.html
.

[fs, 2016-07-22 20:54:31]

Description was changed from

==========
Remove platform/text/ParserUtilities.h

platform/ParsingUtilities.h caters to the same needs, so transition
users of skipString(...) to skipToken(...) and remove
platform/text/ParserUtilities.h.

Committed: https://crrev.com/39cc523b5dbf9d2ddad9483cb27fab8b97e53ec1
Cr-Commit-Position: refs/heads/master@{#407187}
==========

to

==========
Reland of Remove platform/text/ParserUtilities.h

platform/ParsingUtilities.h caters to the same needs, so transition
users of skipString(...) to skipToken(...) and remove
platform/text/ParserUtilities.h.

Committed: https://crrev.com/39cc523b5dbf9d2ddad9483cb27fab8b97e53ec1
Cr-Commit-Position: refs/heads/master@{#407187}
==========

[fs, 2016-07-22 20:55:17]

Tree appears to have cooled down a bit. Relanding.

[fs, 2016-07-22 20:55:25]

The CQ bit was checked by fs@opera.com

[fs, 2016-07-22 20:55:42]

The CQ bit was unchecked by fs@opera.com

[fs, 2016-07-22 20:55:54]

Description was changed from

==========
Reland of Remove platform/text/ParserUtilities.h

platform/ParsingUtilities.h caters to the same needs, so transition
users of skipString(...) to skipToken(...) and remove
platform/text/ParserUtilities.h.

Committed: https://crrev.com/39cc523b5dbf9d2ddad9483cb27fab8b97e53ec1
Cr-Commit-Position: refs/heads/master@{#407187}
==========

to

==========
Reland of Remove platform/text/ParserUtilities.h

platform/ParsingUtilities.h caters to the same needs, so transition
users of skipString(...) to skipToken(...) and remove
platform/text/ParserUtilities.h.
==========

[fs, 2016-07-22 20:55:59]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-07-22 20:56:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 21:01:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-22 21:03:07]

Description was changed from

==========
Reland of Remove platform/text/ParserUtilities.h

platform/ParsingUtilities.h caters to the same needs, so transition
users of skipString(...) to skipToken(...) and remove
platform/text/ParserUtilities.h.
==========

to

==========
Reland of Remove platform/text/ParserUtilities.h

platform/ParsingUtilities.h caters to the same needs, so transition
users of skipString(...) to skipToken(...) and remove
platform/text/ParserUtilities.h.

Committed: https://crrev.com/913442c00dc54f837e9d6b8f0c49d625f91af6b1
Cr-Commit-Position: refs/heads/master@{#407259}
==========

[commit-bot: I haz the power, 2016-07-22 21:03:08]

Patchset 2 (id:??) landed as
https://crrev.com/913442c00dc54f837e9d6b8f0c49d625f91af6b1
Cr-Commit-Position: refs/heads/master@{#407259}

[esprehn, 2016-07-23 08:27:26]

Can you move ParsingUtilities.h into wtf/text? Anything in the top level
platform/ directory will likely need to find a home soon, and this file doesn't
seem like it belongs in platform since it's just generic text stuff. :)

[fs, 2016-07-23 16:04:32]

On 2016/07/23 at 08:27:26, esprehn wrote:
> Can you move ParsingUtilities.h into wtf/text? Anything in the top level
platform/ directory will likely need to find a home soon, and this file doesn't
seem like it belongs in platform since it's just generic text stuff. :)

Can do: https://codereview.chromium.org/2175123002