Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 5 months ago by fs Modified:
4 years, 5 months ago Reviewers:
pdr., Stephen Chennney CC:
blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReland of Remove platform/text/ParserUtilities.h
platform/ParsingUtilities.h caters to the same needs, so transition
users of skipString(...) to skipToken(...) and remove
platform/text/ParserUtilities.h.
Committed: https://crrev.com/913442c00dc54f837e9d6b8f0c49d625f91af6b1
Cr-Commit-Position: refs/heads/master@{#407259}
Patch Set 1 #Patch Set 2 : Remove from blink_platform.gypi #
Created: 4 years, 5 months ago
Messages
Total messages: 29 (17 generated)
The CQ bit was checked by fs@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by fs@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
fs@opera.com changed reviewers: + pdr@chromium.org, schenney@chromium.org
Wow. The transformation is amazing. LGTM.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by fs@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove platform/text/ParserUtilities.h platform/ParsingUtilities.h caters to the same needs, so transition users of skipString(...) to skipToken(...) and remove platform/text/ParserUtilities.h. ========== to ========== Remove platform/text/ParserUtilities.h platform/ParsingUtilities.h caters to the same needs, so transition users of skipString(...) to skipToken(...) and remove platform/text/ParserUtilities.h. Committed: https://crrev.com/39cc523b5dbf9d2ddad9483cb27fab8b97e53ec1 Cr-Commit-Position: refs/heads/master@{#407187} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/39cc523b5dbf9d2ddad9483cb27fab8b97e53ec1 Cr-Commit-Position: refs/heads/master@{#407187}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2179563002/ by mpearson@chromium.org. The reason for reverting is: Likely cause of failures: --- https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/6... unexpected_failures: fast/forms/color/color-suggestion-picker-appearance-zoom125.html fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html fast/forms/color/color-suggestion-picker-appearance-zoom200.html all with the message image diff --- --- also bot: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28... http/tests/images/restyle-decode-error.html in which case there is a renderer crash in this test --- also some other bots for tests fast/forms/color/color-suggestion-picker-appearance.html fast/forms/color/color-suggestion-picker-one-row-appearance.html fast/forms/color/color-suggestion-picker-two-row-appearance.html .
Description was changed from ========== Remove platform/text/ParserUtilities.h platform/ParsingUtilities.h caters to the same needs, so transition users of skipString(...) to skipToken(...) and remove platform/text/ParserUtilities.h. Committed: https://crrev.com/39cc523b5dbf9d2ddad9483cb27fab8b97e53ec1 Cr-Commit-Position: refs/heads/master@{#407187} ========== to ========== Reland of Remove platform/text/ParserUtilities.h platform/ParsingUtilities.h caters to the same needs, so transition users of skipString(...) to skipToken(...) and remove platform/text/ParserUtilities.h. Committed: https://crrev.com/39cc523b5dbf9d2ddad9483cb27fab8b97e53ec1 Cr-Commit-Position: refs/heads/master@{#407187} ==========
Tree appears to have cooled down a bit. Relanding.
The CQ bit was checked by fs@opera.com
The CQ bit was unchecked by fs@opera.com
Description was changed from ========== Reland of Remove platform/text/ParserUtilities.h platform/ParsingUtilities.h caters to the same needs, so transition users of skipString(...) to skipToken(...) and remove platform/text/ParserUtilities.h. Committed: https://crrev.com/39cc523b5dbf9d2ddad9483cb27fab8b97e53ec1 Cr-Commit-Position: refs/heads/master@{#407187} ========== to ========== Reland of Remove platform/text/ParserUtilities.h platform/ParsingUtilities.h caters to the same needs, so transition users of skipString(...) to skipToken(...) and remove platform/text/ParserUtilities.h. ==========
The CQ bit was checked by fs@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Reland of Remove platform/text/ParserUtilities.h platform/ParsingUtilities.h caters to the same needs, so transition users of skipString(...) to skipToken(...) and remove platform/text/ParserUtilities.h. ========== to ========== Reland of Remove platform/text/ParserUtilities.h platform/ParsingUtilities.h caters to the same needs, so transition users of skipString(...) to skipToken(...) and remove platform/text/ParserUtilities.h. Committed: https://crrev.com/913442c00dc54f837e9d6b8f0c49d625f91af6b1 Cr-Commit-Position: refs/heads/master@{#407259} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/913442c00dc54f837e9d6b8f0c49d625f91af6b1 Cr-Commit-Position: refs/heads/master@{#407259}
Message was sent while issue was closed.
Can you move ParsingUtilities.h into wtf/text? Anything in the top level platform/ directory will likely need to find a home soon, and this file doesn't seem like it belongs in platform since it's just generic text stuff. :)
Message was sent while issue was closed.
On 2016/07/23 at 08:27:26, esprehn wrote: > Can you move ParsingUtilities.h into wtf/text? Anything in the top level platform/ directory will likely need to find a home soon, and this file doesn't seem like it belongs in platform since it's just generic text stuff. :) Can do: https://codereview.chromium.org/2175123002 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
