Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5085)

Unified Diff: chrome/browser/ui/webui/media_router/media_router_ui.cc

Issue 2176613003: [Media Router] Clean up issues related code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/media_router/media_router_ui.cc
diff --git a/chrome/browser/ui/webui/media_router/media_router_ui.cc b/chrome/browser/ui/webui/media_router/media_router_ui.cc
index 6b8fba8c1a26b93c1b82aff983fbfd52999d5f3b..f8a4150b6ff257e684780affc15db628d27e9e80 100644
--- a/chrome/browser/ui/webui/media_router/media_router_ui.cc
+++ b/chrome/browser/ui/webui/media_router/media_router_ui.cc
@@ -485,7 +485,7 @@ void MediaRouterUI::CloseRoute(const MediaRoute::Id& route_id) {
void MediaRouterUI::AddIssue(const Issue& issue) { router_->AddIssue(issue); }
-void MediaRouterUI::ClearIssue(const std::string& issue_id) {
+void MediaRouterUI::ClearIssue(const Issue::Id& issue_id) {
router_->ClearIssue(issue_id);
}
@@ -636,11 +636,8 @@ void MediaRouterUI::SendIssueForRouteTimeout(
NOTREACHED();
}
- Issue issue(issue_title, std::string(),
- IssueAction(IssueAction::TYPE_DISMISS),
- std::vector<IssueAction>(), std::string(), Issue::NOTIFICATION,
- false, -1);
- AddIssue(issue);
+ AddIssue(Issue(issue_title, Issue::ActionType::DISMISS,
+ Issue::Severity::NOTIFICATION));
}
void MediaRouterUI::SendIssueForUnableToCast(MediaCastMode cast_mode) {
@@ -652,10 +649,8 @@ void MediaRouterUI::SendIssueForUnableToCast(MediaCastMode cast_mode) {
IDS_MEDIA_ROUTER_ISSUE_UNABLE_TO_CAST_DESKTOP)
: l10n_util::GetStringUTF8(
IDS_MEDIA_ROUTER_ISSUE_CREATE_ROUTE_TIMEOUT_FOR_TAB);
- AddIssue(Issue(issue_title, std::string(),
- IssueAction(IssueAction::TYPE_DISMISS),
- std::vector<IssueAction>(), std::string(), Issue::WARNING,
- false, -1));
+ AddIssue(
+ Issue(issue_title, Issue::ActionType::DISMISS, Issue::Severity::WARNING));
}
GURL MediaRouterUI::GetFrameURL() const {

Powered by Google App Engine
This is Rietveld 408576698