Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: chrome/browser/media/router/issue_manager_unittest.cc

Issue 2176613003: [Media Router] Clean up issues related code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/issue_manager_unittest.cc
diff --git a/chrome/browser/media/router/issue_manager_unittest.cc b/chrome/browser/media/router/issue_manager_unittest.cc
index 2c67b3c091772c39d7cd7ff30bef570e18848310..0e3b9767f35408eb0c4853e437458d9808cc71eb 100644
--- a/chrome/browser/media/router/issue_manager_unittest.cc
+++ b/chrome/browser/media/router/issue_manager_unittest.cc
@@ -16,9 +16,11 @@ namespace {
const char kTestRouteId[] = "routeId";
Issue CreateTestIssue(const std::string& route_id) {
- return Issue("title", "message", IssueAction(IssueAction::TYPE_DISMISS),
- std::vector<IssueAction>(), route_id, Issue::WARNING, false,
- 12345);
+ Issue issue("title", Issue::ActionType::DISMISS, Issue::Severity::WARNING);
+ issue.set_message("message");
+ issue.set_route_id(route_id);
+ issue.set_help_page_id(12345);
+ return issue;
}
class IssueManagerUnitTest : public ::testing::Test {
@@ -54,7 +56,7 @@ TEST_F(IssueManagerUnitTest, ClearIssue) {
Issue issue = CreateTestIssue(kTestRouteId);
// Remove an issue that doesn't exist.
- manager_.ClearIssue("id");
+ manager_.ClearIssue(999);
// Add initial issue.
manager_.AddIssue(issue);
@@ -65,7 +67,7 @@ TEST_F(IssueManagerUnitTest, ClearIssue) {
EXPECT_EQ(0u, manager_.GetIssueCount());
// Remove an issue that doesn't exist.
- manager_.ClearIssue("id");
+ manager_.ClearIssue(999);
EXPECT_EQ(0u, manager_.GetIssueCount());
}

Powered by Google App Engine
This is Rietveld 408576698