Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4806)

Unified Diff: chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h

Issue 2176613003: [Media Router] Clean up issues related code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h
diff --git a/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h b/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h
index 4a9156d42c7a6c7be3f690c589fbf13f53edfc5b..8d8e15204f0661a2cecd3dde78bf976c79987efd 100644
--- a/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h
+++ b/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h
@@ -48,9 +48,8 @@ class MediaRouterWebUIMessageHandler : public content::WebUIMessageHandler {
const MediaRoute* route);
void ReturnSearchResult(const std::string& sink_id);
- // Does not take ownership of |issue|. Note that |issue| can be nullptr, when
- // there are no more issues.
- void UpdateIssue(const Issue* issue);
+ void UpdateIssue(const Issue& issue);
+ void ClearIssue();
// Updates the maximum dialog height to allow the WebUI properly scale when
// the browser window changes.
@@ -90,7 +89,7 @@ class MediaRouterWebUIMessageHandler : public content::WebUIMessageHandler {
// Performs an action for an Issue of |type|.
// |args| contains additional parameter that varies based on |type|.
// Returns |true| if the action was successfully performed.
- bool ActOnIssueType(const IssueAction::Type& type,
+ bool ActOnIssueType(IssueInfo::Action type,
const base::DictionaryValue* args);
// May update the first run flow related properties in the WebUI. This is

Powered by Google App Engine
This is Rietveld 408576698