Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3765)

Unified Diff: chrome/browser/ui/toolbar/media_router_action_controller.cc

Issue 2176613003: [Media Router] Clean up issues related code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/media_router_action_controller.cc
diff --git a/chrome/browser/ui/toolbar/media_router_action_controller.cc b/chrome/browser/ui/toolbar/media_router_action_controller.cc
index bc46d00cb20b96a8cddf54d9589457ef7f914065..9db79c88093b92967994662d81c8e44971ebdc34 100644
--- a/chrome/browser/ui/toolbar/media_router_action_controller.cc
+++ b/chrome/browser/ui/toolbar/media_router_action_controller.cc
@@ -22,12 +22,15 @@ MediaRouterActionController::MediaRouterActionController(Profile* profile)
MediaRouterActionController::~MediaRouterActionController() {
DCHECK_EQ(dialog_count_, 0u);
- UnregisterObserver(); // media_router::IssuesObserver.
}
-void MediaRouterActionController::OnIssueUpdated(
- const media_router::Issue* issue) {
- has_issue_ = issue != nullptr;
+void MediaRouterActionController::OnIssue(const media_router::Issue& issue) {
+ has_issue_ = true;
+ MaybeAddOrRemoveAction();
+}
+
+void MediaRouterActionController::OnIssuesCleared() {
+ has_issue_ = false;
MaybeAddOrRemoveAction();
}
@@ -67,7 +70,7 @@ MediaRouterActionController::MediaRouterActionController(
component_action_delegate_(component_action_delegate),
component_migration_helper_(component_migration_helper) {
DCHECK(profile_);
- RegisterObserver(); // media_router::IssuesObserver.
+ media_router::IssuesObserver::Init();
pref_change_registrar_.Init(profile->GetPrefs());
pref_change_registrar_.Add(
prefs::kToolbarMigratedComponentActionStatus,

Powered by Google App Engine
This is Rietveld 408576698