Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3114)

Unified Diff: chrome/browser/media/router/issue_manager.h

Issue 2176613003: [Media Router] Clean up issues related code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media/router/issue.cc ('k') | chrome/browser/media/router/issue_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/router/issue_manager.h
diff --git a/chrome/browser/media/router/issue_manager.h b/chrome/browser/media/router/issue_manager.h
index 0c9ae27cb64b584a1269f6b997f92c16e60851ca..b276a14652e31f32b7cb026e84a03a09295c1058 100644
--- a/chrome/browser/media/router/issue_manager.h
+++ b/chrome/browser/media/router/issue_manager.h
@@ -7,6 +7,7 @@
#include <stddef.h>
+#include <memory>
#include <vector>
#include "base/containers/hash_tables.h"
@@ -25,27 +26,14 @@ class IssueManager {
IssueManager();
~IssueManager();
- // Adds an issue.
- // |issue|: Issue to be added. Must have unique ID.
- void AddIssue(const Issue& issue);
+ // Adds an issue. No-ops if the issue already exists.
+ // |issue_info|: Info of issue to be added.
+ void AddIssue(const IssueInfo& issue_info);
// Removes an issue when user has noted it is resolved.
// |issue_id|: Issue::Id of the issue to be removed.
void ClearIssue(const Issue::Id& issue_id);
- // Gets the number of unresolved issues.
- size_t GetIssueCount() const;
-
- // Removes all unresolved issues.
- void ClearAllIssues();
-
- // Removes all unresolved global issues.
- void ClearGlobalIssues();
-
- // Removes all unresolved issues with RouteId.
- // |route_id|: ID of the media route whose issues are to be cleared.
- void ClearIssuesWithRouteId(const MediaRoute::Id& route_id);
-
// Registers an issue observer |observer|. The observer will be triggered
// when the highest priority issue changes.
// If there is already an observer registered with this instance, do nothing.
@@ -59,17 +47,17 @@ class IssueManager {
private:
// Checks if the current top issue has changed. Updates |top_issue_|.
- // If |top_issue_| has changed, issues in |issues_observers_| will be
+ // If |top_issue_| has changed, observers in |issues_observers_| will be
// notified of the new top issue.
void MaybeUpdateTopIssue();
- std::vector<Issue> issues_;
+ std::vector<std::unique_ptr<Issue>> issues_;
// IssueObserver insteances are not owned by the manager.
base::ObserverList<IssuesObserver> issues_observers_;
- // The ID of the current top issue.
- Issue::Id top_issue_id_;
+ // ID of the top Issue in |issues_|, or |nullptr| if there are no issues.
+ const Issue* top_issue_;
DISALLOW_COPY_AND_ASSIGN(IssueManager);
};
« no previous file with comments | « chrome/browser/media/router/issue.cc ('k') | chrome/browser/media/router/issue_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698