[Media Router] Clean up issues related code.

chrome/browser/ui/toolbar/media_router_action.cc

Index: chrome/browser/ui/toolbar/media_router_action.cc
diff --git a/chrome/browser/ui/toolbar/media_router_action.cc b/chrome/browser/ui/toolbar/media_router_action.cc
index d8b04d5622481c5ffedd028c24d64b9e34775a8a..7b700092bc81d11cdeb839615fb257075da00e0c 100644
--- a/chrome/browser/ui/toolbar/media_router_action.cc
+++ b/chrome/browser/ui/toolbar/media_router_action.cc
@@ -54,11 +54,10 @@ MediaRouterAction::MediaRouterAction(Browser* browser,
   DCHECK(toolbar_actions_bar_);
   tab_strip_model_observer_.Add(browser_->tab_strip_model());
   toolbar_actions_bar_observer_.Add(toolbar_actions_bar_);
-  RegisterObserver();
+  IssuesObserver::Init();
 }
 
 MediaRouterAction::~MediaRouterAction() {
-  UnregisterObserver();
 }
 
 // static
@@ -165,8 +164,13 @@ bool MediaRouterAction::DisabledClickOpensMenu() const {
   return false;
 }
 
-void MediaRouterAction::OnIssueUpdated(const media_router::Issue* issue) {
-  issue_.reset(issue ? new media_router::Issue(*issue) : nullptr);
+void MediaRouterAction::OnIssue(const media_router::Issue& issue) {
+  current_issue_ = issue.info();
+  MaybeUpdateIcon();
+}
+
+void MediaRouterAction::OnIssuesCleared() {
+  current_issue_.reset();
   MaybeUpdateIcon();
 }
 
@@ -266,11 +270,13 @@ void MediaRouterAction::MaybeUpdateIcon() {
 
 gfx::VectorIconId MediaRouterAction::GetCurrentIcon() const {
   // Highest priority is to indicate whether there's an issue.
-  if (issue_) {
-    if (issue_->severity() == media_router::Issue::FATAL)
+  if (current_issue_.has_value()) {
+    media_router::IssueInfo::Severity severity = current_issue_->severity;

[msw, 2016/12/13 18:45:39]

optional nit: just inline current_issue_->severity in the conditionals below

[imcheng, 2016/12/13 19:22:47]

Acknowledged.

+    if (severity == media_router::IssueInfo::Severity::FATAL)
       return gfx::VectorIconId::MEDIA_ROUTER_ERROR;
-    if (issue_->severity() == media_router::Issue::WARNING)
+    else if (severity == media_router::IssueInfo::Severity::WARNING)

[msw, 2016/12/13 18:45:39]

No else after return.

[imcheng, 2016/12/13 19:22:47]

Done.

       return gfx::VectorIconId::MEDIA_ROUTER_WARNING;
+    // Fall through for Severity::NOTIFICATION.
   }
 
   return has_local_display_route_ ? gfx::VectorIconId::MEDIA_ROUTER_ACTIVE