chrome/browser/ui/toolbar/media_router_action_unittest.cc - Issue 2176613003: [Media Router] Clean up issues related code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/media_router_action_unittest.cc

Issue 2176613003: [Media Router] Clean up issues related code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/router/mojo/media_router_struct_traits.h ('K') | « chrome/browser/ui/toolbar/media_router_action_controller_unittest.cc ('k') | chrome/browser/ui/webui/media_router/media_router_ui.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/toolbar/media_router_action_unittest.cc

diff --git a/chrome/browser/ui/toolbar/media_router_action_unittest.cc b/chrome/browser/ui/toolbar/media_router_action_unittest.cc

index c85cc323c6de45853534bde100ccc7d0122ee06b..9d35fecc8fb1b8fbf9787c617eb9690ce7740f3a 100644

--- a/chrome/browser/ui/toolbar/media_router_action_unittest.cc

+++ b/chrome/browser/ui/toolbar/media_router_action_unittest.cc

@@ -81,34 +81,18 @@ class MediaRouterActionUnitTest : public MediaRouterWebUITest {

MediaRouterActionUnitTest()

: MediaRouterWebUITest(true),

toolbar_model_(nullptr),

- fake_issue_notification_(media_router::Issue(

+ fake_issue_notification_(media_router::IssueInfo(

"title notification",

- "message notification",

- media_router::IssueAction(media_router::IssueAction::TYPE_DISMISS),

- std::vector<media_router::IssueAction>(),

- "route_id",

- media_router::Issue::NOTIFICATION,

- false,

- -1)),

- fake_issue_warning_(

- media_router::Issue("title warning",

- "message warning",

- media_router::IssueAction(

- media_router::IssueAction::TYPE_LEARN_MORE),

- std::vector<media_router::IssueAction>(),

- "route_id",

- media_router::Issue::WARNING,

- false,

- 12345)),

- fake_issue_fatal_(media_router::Issue(

- "title fatal",

- "message fatal",

- media_router::IssueAction(media_router::IssueAction::TYPE_DISMISS),

- std::vector<media_router::IssueAction>(),

- "route_id",

- media_router::Issue::FATAL,

- true,

- -1)),

+ media_router::IssueInfo::Action::DISMISS,

+ media_router::IssueInfo::Severity::NOTIFICATION)),

+ fake_issue_warning_(media_router::IssueInfo(

+ "title warning",

+ media_router::IssueInfo::Action::LEARN_MORE,

+ media_router::IssueInfo::Severity::WARNING)),

+ fake_issue_fatal_(

+ media_router::IssueInfo("title fatal",

+ media_router::IssueInfo::Action::DISMISS,

+ media_router::IssueInfo::Severity::FATAL)),

fake_source1_("fakeSource1"),

fake_source2_("fakeSource2"),

active_icon_(GetIcon(gfx::VectorIconId::MEDIA_ROUTER_ACTIVE)),