Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: chrome/browser/ui/webui/media_router/media_router_ui.cc

Issue 2176613003: [Media Router] Clean up issues related code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IssueObserver init behavior and use StructTraits Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/media_router/media_router_ui.cc
diff --git a/chrome/browser/ui/webui/media_router/media_router_ui.cc b/chrome/browser/ui/webui/media_router/media_router_ui.cc
index 21fc8393995fbcbcf938e882865df3420030fbf0..e118e10745294fc62115d244e971d49b5717ed8a 100644
--- a/chrome/browser/ui/webui/media_router/media_router_ui.cc
+++ b/chrome/browser/ui/webui/media_router/media_router_ui.cc
@@ -196,8 +196,6 @@ MediaRouterUI::MediaRouterUI(content::WebUI* web_ui)
}
MediaRouterUI::~MediaRouterUI() {
- if (issues_observer_) issues_observer_->UnregisterObserver();
-
if (query_result_manager_.get()) query_result_manager_->RemoveObserver(this);
if (presentation_service_delegate_.get())
presentation_service_delegate_->RemoveDefaultPresentationRequestObserver(
@@ -363,9 +361,8 @@ void MediaRouterUI::UIInitialized() {
ui_initialized_ = true;
// Register for Issue updates.
- if (!issues_observer_)
- issues_observer_.reset(new UIIssuesObserver(router_, this));
- issues_observer_->RegisterObserver();
+ issues_observer_.reset(new UIIssuesObserver(router_, this));
+ issues_observer_->Init();
}
bool MediaRouterUI::CreateRoute(const MediaSink::Id& sink_id,
@@ -486,9 +483,11 @@ void MediaRouterUI::CloseRoute(const MediaRoute::Id& route_id) {
router_->TerminateRoute(route_id);
}
-void MediaRouterUI::AddIssue(const Issue& issue) { router_->AddIssue(issue); }
+void MediaRouterUI::AddIssue(const IssueInfo& issue) {
+ router_->AddIssue(issue);
+}
-void MediaRouterUI::ClearIssue(const std::string& issue_id) {
+void MediaRouterUI::ClearIssue(const Issue::Id& issue_id) {
router_->ClearIssue(issue_id);
}
@@ -626,11 +625,8 @@ void MediaRouterUI::SendIssueForRouteTimeout(
NOTREACHED();
}
- Issue issue(issue_title, std::string(),
- IssueAction(IssueAction::TYPE_DISMISS),
- std::vector<IssueAction>(), std::string(), Issue::NOTIFICATION,
- false, -1);
- AddIssue(issue);
+ AddIssue(IssueInfo(issue_title, IssueInfo::Action::DISMISS,
+ IssueInfo::Severity::NOTIFICATION));
}
void MediaRouterUI::SendIssueForUnableToCast(MediaCastMode cast_mode) {
@@ -642,10 +638,8 @@ void MediaRouterUI::SendIssueForUnableToCast(MediaCastMode cast_mode) {
IDS_MEDIA_ROUTER_ISSUE_UNABLE_TO_CAST_DESKTOP)
: l10n_util::GetStringUTF8(
IDS_MEDIA_ROUTER_ISSUE_CREATE_ROUTE_TIMEOUT_FOR_TAB);
- AddIssue(Issue(issue_title, std::string(),
- IssueAction(IssueAction::TYPE_DISMISS),
- std::vector<IssueAction>(), std::string(), Issue::WARNING,
- false, -1));
+ AddIssue(IssueInfo(issue_title, IssueInfo::Action::DISMISS,
+ IssueInfo::Severity::WARNING));
}
GURL MediaRouterUI::GetFrameURL() const {

Powered by Google App Engine
This is Rietveld 408576698