[Media Router] Clean up issues related code.

chrome/browser/ui/toolbar/media_router_action_controller_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 #include <string>
 
 #include "chrome/browser/media/router/mock_media_router.h"
 #include "chrome/browser/ui/toolbar/component_toolbar_actions_factory.h"
 #include "chrome/browser/ui/toolbar/media_router_action_controller.h"
@@ skipping 28 matching lines @@
     return has_media_router_action_;
   }
 
  private:
   bool has_media_router_action_ = false;
 };
 
 class MediaRouterActionControllerUnitTest : public MediaRouterWebUITest {
  public:
   MediaRouterActionControllerUnitTest()
-      : issue_(media_router::Issue(
+      : issue_(media_router::IssueInfo(
             "title notification",
-            "message notification",
-            media_router::IssueAction(media_router::IssueAction::TYPE_DISMISS),
-            std::vector<media_router::IssueAction>(),
-            "route_id",
-            media_router::Issue::NOTIFICATION,
-            false,
-            -1)),
+            media_router::IssueInfo::Action::DISMISS,
+            media_router::IssueInfo::Severity::NOTIFICATION)),
         source1_("fakeSource1"),
         source2_("fakeSource2") {}
 
   ~MediaRouterActionControllerUnitTest() override {}
 
   // MediaRouterWebUITest:
   void SetUp() override {
     MediaRouterWebUITest::SetUp();
 
     router_.reset(new media_router::MockMediaRouter());
@@ skipping 30 matching lines @@
         ComponentToolbarActionsFactory::kMediaRouterActionId);
   }
 
   void SetAlwaysShowActionPref(bool always_show) {
     component_migration_helper_->SetComponentActionPref(
         ComponentToolbarActionsFactory::kMediaRouterActionId, always_show);
   }
 
   MediaRouterActionController* controller() { return controller_.get(); }
 
-  const media_router::Issue* issue() { return &issue_; }
+  const media_router::Issue& issue() { return issue_; }
   const std::vector<media_router::MediaRoute>& local_display_route_list()
       const {
     return local_display_route_list_;
   }
   const std::vector<media_router::MediaRoute>& non_local_display_route_list()
       const {
     return non_local_display_route_list_;
   }
   const std::vector<media_router::MediaRoute::Id>& empty_route_id_list() const {
     return empty_route_id_list_;
@@ skipping 26 matching lines @@
                                 empty_route_id_list());
   EXPECT_TRUE(controller()->has_local_display_route_);
   EXPECT_TRUE(ActionExists());
   // Removing the local route should hide the icon.
   controller()->OnRoutesUpdated(non_local_display_route_list(),
                                 empty_route_id_list());
   EXPECT_FALSE(controller()->has_local_display_route_);
   EXPECT_FALSE(ActionExists());
 
   // Creating an issue should show the action icon.
-  controller()->OnIssueUpdated(issue());
+  controller()->OnIssue(issue());
   EXPECT_TRUE(controller()->has_issue_);
   EXPECT_TRUE(ActionExists());
   // Removing the issue should hide the icon.
-  controller()->OnIssueUpdated(nullptr);
+  controller()->OnIssuesCleared();
   EXPECT_FALSE(controller()->has_issue_);
   EXPECT_FALSE(ActionExists());
 
-  controller()->OnIssueUpdated(issue());
+  controller()->OnIssue(issue());
   controller()->OnRoutesUpdated(local_display_route_list(),
                                 empty_route_id_list());
-  controller()->OnIssueUpdated(nullptr);
+  controller()->OnIssuesCleared();
   // When the issue disappears, the icon should remain visible if there's
   // a local route.
   EXPECT_TRUE(ActionExists());
   controller()->OnRoutesUpdated(std::vector<media_router::MediaRoute>(),
                                 empty_route_id_list());
   EXPECT_FALSE(ActionExists());
 }
 
 TEST_F(MediaRouterActionControllerUnitTest, EphemeralIconForDialog) {
   EXPECT_FALSE(ActionExists());
@@ skipping 17 matching lines @@
                                 empty_route_id_list());
   // Hiding the dialog while there are local routes shouldn't hide the icon.
   controller()->OnDialogHidden();
   EXPECT_TRUE(ActionExists());
   controller()->OnRoutesUpdated(non_local_display_route_list(),
                                 empty_route_id_list());
   EXPECT_FALSE(ActionExists());
 
   controller()->OnDialogShown();
   EXPECT_TRUE(ActionExists());
-  controller()->OnIssueUpdated(issue());
+  controller()->OnIssue(issue());
   // Hiding the dialog while there is an issue shouldn't hide the icon.
   controller()->OnDialogHidden();
   EXPECT_TRUE(ActionExists());
-  controller()->OnIssueUpdated(nullptr);
+  controller()->OnIssuesCleared();
   EXPECT_FALSE(ActionExists());
 }
 
 TEST_F(MediaRouterActionControllerUnitTest, ObserveAlwaysShowPrefChange) {
   EXPECT_FALSE(ActionExists());
 
   SetAlwaysShowActionPref(true);
   EXPECT_TRUE(ActionExists());
 
   controller()->OnRoutesUpdated(local_display_route_list(),
                                 empty_route_id_list());
   SetAlwaysShowActionPref(false);
   // Unchecking the option while having a local route shouldn't hide the icon.
   EXPECT_TRUE(ActionExists());
 
   SetAlwaysShowActionPref(true);
   controller()->OnRoutesUpdated(non_local_display_route_list(),
                                 empty_route_id_list());
   // Removing the local route should not hide the icon.
   EXPECT_TRUE(ActionExists());
 
   SetAlwaysShowActionPref(false);
   EXPECT_FALSE(ActionExists());
 }