[Media Router] Clean up issues related code.

chrome/browser/media/router/issues_observer.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_MEDIA_ROUTER_ISSUES_OBSERVER_H_
 #define CHROME_BROWSER_MEDIA_ROUTER_ISSUES_OBSERVER_H_
 
 #include "base/macros.h"
 #include "chrome/browser/media/router/issue.h"
 
 namespace media_router {
 
 class MediaRouter;
 
 // Base class for observing Media Router Issue. There is at most one Issue
 // at any given time.
 class IssuesObserver {
  public:
   explicit IssuesObserver(MediaRouter* router);
   virtual ~IssuesObserver();
 
-  void RegisterObserver();
-  void UnregisterObserver();
+  // Registers with Media Router to start observing for Issues. No-ops if Init()
+  // has already been called before.
+  void Init();
 
   // Called when there is an updated Media Router Issue.
   // If |issue| is nullptr, then there is currently no issue.

[mark a. foltz, 2016/11/29 21:27:07]

Document that the lifetime of |issue| is tied to the IssueManager.

[imcheng, 2016/12/05 23:18:17]

Done.

   virtual void OnIssueUpdated(const Issue* issue) {}

[mark a. foltz, 2016/11/29 21:27:07]

Would it make more sense to pass a const reference?  That way the caller is not
tempted to keep a pointer to an Issue it doesn't own.

[imcheng, 2016/12/05 23:18:17]

Unfortunately we are also using this API to notify the observer that there are
no more issues. I would prefer that generally since as you say, we can make
OnIssueUpdated use a const ref. I can do that in a separate patch set.

 
  private:
   MediaRouter* router_;
+  bool initialized_;
 
   DISALLOW_COPY_AND_ASSIGN(IssuesObserver);
 };
 
 }  // namespace media_router
 
 #endif  // CHROME_BROWSER_MEDIA_ROUTER_ISSUES_OBSERVER_H_