Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: chrome/browser/ui/toolbar/media_router_action_controller_unittest.cc

Issue 2176613003: [Media Router] Clean up issues related code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IssueObserver init behavior and use StructTraits Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <memory> 5 #include <memory>
6 #include <string> 6 #include <string>
7 7
8 #include "chrome/browser/media/router/mock_media_router.h" 8 #include "chrome/browser/media/router/mock_media_router.h"
9 #include "chrome/browser/ui/toolbar/component_toolbar_actions_factory.h" 9 #include "chrome/browser/ui/toolbar/component_toolbar_actions_factory.h"
10 #include "chrome/browser/ui/toolbar/media_router_action_controller.h" 10 #include "chrome/browser/ui/toolbar/media_router_action_controller.h"
(...skipping 28 matching lines...) Expand all
39 return has_media_router_action_; 39 return has_media_router_action_;
40 } 40 }
41 41
42 private: 42 private:
43 bool has_media_router_action_ = false; 43 bool has_media_router_action_ = false;
44 }; 44 };
45 45
46 class MediaRouterActionControllerUnitTest : public MediaRouterTest { 46 class MediaRouterActionControllerUnitTest : public MediaRouterTest {
47 public: 47 public:
48 MediaRouterActionControllerUnitTest() 48 MediaRouterActionControllerUnitTest()
49 : issue_(media_router::Issue( 49 : issue_(media_router::IssueInfo(
50 "title notification", 50 "title notification",
51 "message notification", 51 media_router::IssueInfo::Action::DISMISS,
52 media_router::IssueAction(media_router::IssueAction::TYPE_DISMISS), 52 media_router::IssueInfo::Severity::NOTIFICATION)),
53 std::vector<media_router::IssueAction>(),
54 "route_id",
55 media_router::Issue::NOTIFICATION,
56 false,
57 -1)),
58 source1_("fakeSource1"), 53 source1_("fakeSource1"),
59 source2_("fakeSource2") {} 54 source2_("fakeSource2") {}
60 55
61 ~MediaRouterActionControllerUnitTest() override {} 56 ~MediaRouterActionControllerUnitTest() override {}
62 57
63 // MediaRouterTest: 58 // MediaRouterTest:
64 void SetUp() override { 59 void SetUp() override {
65 MediaRouterTest::SetUp(); 60 MediaRouterTest::SetUp();
66 61
67 router_.reset(new media_router::MockMediaRouter()); 62 router_.reset(new media_router::MockMediaRouter());
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 181
187 SetAlwaysShowActionPref(true); 182 SetAlwaysShowActionPref(true);
188 controller()->OnRoutesUpdated(non_local_display_route_list(), 183 controller()->OnRoutesUpdated(non_local_display_route_list(),
189 empty_route_id_list()); 184 empty_route_id_list());
190 // Removing the local route should not hide the icon. 185 // Removing the local route should not hide the icon.
191 EXPECT_TRUE(ActionExists()); 186 EXPECT_TRUE(ActionExists());
192 187
193 SetAlwaysShowActionPref(false); 188 SetAlwaysShowActionPref(false);
194 EXPECT_FALSE(ActionExists()); 189 EXPECT_FALSE(ActionExists());
195 } 190 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698