[Media Router] Clean up issues related code.

chrome/browser/ui/toolbar/media_router_action.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_TOOLBAR_MEDIA_ROUTER_ACTION_H_
 #define CHROME_BROWSER_UI_TOOLBAR_MEDIA_ROUTER_ACTION_H_
 
 #include <memory>
 #include <string>
 
 #include "base/macros.h"
+#include "base/optional.h"
 #include "base/scoped_observer.h"
 #include "chrome/browser/media/router/issues_observer.h"
 #include "chrome/browser/media/router/media_routes_observer.h"
 #include "chrome/browser/ui/tabs/tab_strip_model_observer.h"
 #include "chrome/browser/ui/toolbar/media_router_contextual_menu.h"
 #include "chrome/browser/ui/toolbar/toolbar_action_view_controller.h"
 #include "chrome/browser/ui/toolbar/toolbar_actions_bar.h"
 #include "chrome/browser/ui/toolbar/toolbar_actions_bar_observer.h"
 #include "ui/gfx/vector_icons_public.h"
 
@@ skipping 82 matching lines @@
   // Checks if the current icon of MediaRouterAction has changed. If so,
   // updates |current_icon_|.
   void MaybeUpdateIcon();
 
   gfx::VectorIconId GetCurrentIcon() const;
 
   // The current icon to show. This is updated based on the current issues and
   // routes since |this| is an IssueObserver and MediaRoutesObserver.
   gfx::VectorIconId current_icon_;
 
-  // The current issue shown in the Media Router WebUI. Can be null. It is set
-  // in OnIssueUpdated(), which is called by the IssueManager.
-  std::unique_ptr<media_router::Issue> issue_;
+  // The severity of the current issue shown in the Media Router WebUI, or not
+  // set if there are no issues currently.
+  // Set in OnIssueUpdated(), which is called by the IssueManager.
+  base::Optional<media_router::IssueInfo::Severity> current_issue_severity_;

[mark a. foltz, 2016/10/18 21:13:44]

It seems odd to cherry-pick one value out of the data model object.  Is there an
issue with holding a unique_ptr<Issue> as was done before?  Or is this to avoid
a potential copy?

[imcheng, 2016/11/18 23:45:14]

This was an issue before because of how we allocated a new issue id with
copy-constructing Issue (and also we didn't have use for other fields). I
changed this to make a copy of the IssueInfo.

 
   // Whether a local displayable active route exists.
   bool has_local_display_route_;
 
   // Whether the Media Router dialog is shown in the current tab.
   // This should only be updated in OnDialogShown() and OnDialogHidden().
   bool has_dialog_;
 
   ToolbarActionViewDelegate* delegate_;
 
   Browser* const browser_;
   ToolbarActionsBar* const toolbar_actions_bar_;
 
   // The delegate to handle platform-specific implementations.
   std::unique_ptr<MediaRouterActionPlatformDelegate> platform_delegate_;
 
   MediaRouterContextualMenu contextual_menu_;
 
   ScopedObserver<TabStripModel, TabStripModelObserver>
       tab_strip_model_observer_;
   ScopedObserver<ToolbarActionsBar, ToolbarActionsBarObserver>
       toolbar_actions_bar_observer_;
 
   base::WeakPtrFactory<MediaRouterAction> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(MediaRouterAction);
 };
 
 #endif  // CHROME_BROWSER_UI_TOOLBAR_MEDIA_ROUTER_ACTION_H_