Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2176613002: Native try-catch syntax parsing should not crash. (Closed)

Created:
4 years, 5 months ago by Yang
Modified:
4 years, 5 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Native try-catch syntax parsing should not crash. R=littledan@chromium.org BUG=chromium:630559 Committed: https://crrev.com/986814218b907cbac244a3624362ee9351f6badb Cr-Commit-Position: refs/heads/master@{#37996}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M src/parsing/parser.cc View 1 chunk +10 lines, -10 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-630559.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Yang
4 years, 5 months ago (2016-07-22 11:19:31 UTC) #1
Dan Ehrenberg
lgtm
4 years, 5 months ago (2016-07-22 16:16:52 UTC) #3
Dan Ehrenberg
Do you want to somehow reject try { } %finally { } ?
4 years, 5 months ago (2016-07-22 16:17:34 UTC) #4
Yang
On 2016/07/22 16:17:34, Dan Ehrenberg wrote: > Do you want to somehow reject try { ...
4 years, 5 months ago (2016-07-25 05:11:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176613002/1
4 years, 5 months ago (2016-07-25 05:11:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 05:32:18 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 05:32:32 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/986814218b907cbac244a3624362ee9351f6badb
Cr-Commit-Position: refs/heads/master@{#37996}

Powered by Google App Engine
This is Rietveld 408576698