Issue 21766002: NodeList.item() does not behave according to specification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21766002: NodeList.item() does not behave according to specification (Closed)

Created:
7 years, 4 months ago by do-not-use

Modified:
7 years, 4 months ago

Reviewers:
haraken, tkent, arv (Not doing code reviews)

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, do-not-use, lgombos, jsbell

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

NodeList.item() does not behave according to specification NodeList.item() does not behave according to specification: http://dom.spec.whatwg.org/#nodelist Namely, we should not throw if the index is negative (meaning we should drop the [IsIndex] extended attribute) and the argument should be mandatory. This behavior is consistent with both IE10 and Firefox. BUG=237739 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155514

Patch Set 1 #

Patch Set 2 : Add extra check #

Patch Set 3 : Simplify link tag #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -3 lines)			Patch
A	LayoutTests/fast/dom/nodelist-item-parameter.html	View	1 2	1 chunk	+27 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/nodelist-item-parameter-expected.txt	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/NodeList.idl	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/21766002/10001

7 years, 4 months ago (2013-08-05 05:41:59 UTC) #5

Message was sent while issue was closed.

Change committed as 155514

Expand Messages | Collapse Messages