Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2176573002: [Merge to 2785] Hide the DIV containing password import/export buttons (Closed)

Created:
4 years, 5 months ago by vabr (Chromium)
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Merge to 2785] Hide the DIV containing password import/export buttons The import/export feature for passwords is currently behind a flag. However, the settings WebUI hides the controls instead of the containing DIV. As a result, on loading the settings, the space for the controls is briefly taken into consideration and a vertical scrollbar shows up. This CL hides the containing DIV instead of the individual controls. Test steps: With chrome://flags/#password-import-export enabled, observe that about:settings/passwords looks the same as without the patch. With chrome://flags/#password-import-export disabled, observe that during reloading of about:settings/passwords, no vertical scroll bar is flashing/seen. BUG=626634 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2154223002 Cr-Commit-Position: refs/heads/master@{#406616} (cherry picked from commit 33bd96dd8b9c462fe5a83d43a6ce535321907ca5) Committed: https://chromium.googlesource.com/chromium/src/+/110f6b0a9c2fd64a1576842756e3bd0f6e8b2820

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/browser/resources/options/password_manager.html View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/password_manager.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
vabr (Chromium)
4 years, 5 months ago (2016-07-22 08:44:47 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
110f6b0a9c2fd64a1576842756e3bd0f6e8b2820.

Powered by Google App Engine
This is Rietveld 408576698