Chromium Code Reviews
Description[Merge to 2785] Hide the DIV containing password import/export buttons
The import/export feature for passwords is currently behind a flag. However,
the settings WebUI hides the controls instead of the containing DIV. As a
result, on loading the settings, the space for the controls is briefly
taken into consideration and a vertical scrollbar shows up.
This CL hides the containing DIV instead of the individual controls.
Test steps:
With chrome://flags/#password-import-export enabled, observe that about:settings/passwords looks the same as without the patch. With chrome://flags/#password-import-export disabled, observe that during reloading of about:settings/passwords, no vertical scroll bar is flashing/seen.
BUG=626634
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2154223002
Cr-Commit-Position: refs/heads/master@{#406616}
(cherry picked from commit 33bd96dd8b9c462fe5a83d43a6ce535321907ca5)
Committed: https://chromium.googlesource.com/chromium/src/+/110f6b0a9c2fd64a1576842756e3bd0f6e8b2820
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
||||||||||||||||||||||||||||