Move StringMatch to String::IndexOf

Move StringMatch to String::IndexOf

This will get a new call site in an upcoming commit, move it to String
so it's accessible from without runtime-strings.cc.

BUG=

Committed: https://crrev.com/428dde9ac79e3baead2e1cd384dfeab23de143c1
Cr-Commit-Position: refs/heads/master@{#37974}

[jgruber, 2016-07-22 07:43:09]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 07:43:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-07-22 07:50:44]

This will be used in CallSite.toString.

[jgruber, 2016-07-22 07:51:19]

jgruber@chromium.org changed reviewers:
+ yangguo@chromium.org

[jgruber, 2016-07-22 07:51:20]

This will be used in CallSite.toString.

[commit-bot: I haz the power, 2016-07-22 08:06:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 08:06:58]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-07-22 08:34:03]

lgtm

https://codereview.chromium.org/2176553002/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2176553002/diff/1/src/objects.h#newcode9032
src/objects.h:9032: // and should check that pat->length() + start_index <=
sub->length().
looks like this second requirement is not necessary. We check for that and
return -1.

[jgruber, 2016-07-22 09:22:30]

https://codereview.chromium.org/2176553002/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2176553002/diff/1/src/objects.h#newcode9032
src/objects.h:9032: // and should check that pat->length() + start_index <=
sub->length().
On 2016/07/22 08:34:03, Yang wrote:
> looks like this second requirement is not necessary. We check for that and
> return -1.

Done.

[jgruber, 2016-07-22 09:22:54]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2016-07-22 09:22:55]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2176553002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2016-07-22 09:23:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 09:49:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-22 09:52:38]

Description was changed from

==========
Move StringMatch to String::IndexOf

This will get a new call site in an upcoming commit, move it to String
so it's accessible from without runtime-strings.cc.

BUG=
==========

to

==========
Move StringMatch to String::IndexOf

This will get a new call site in an upcoming commit, move it to String
so it's accessible from without runtime-strings.cc.

BUG=

Committed: https://crrev.com/428dde9ac79e3baead2e1cd384dfeab23de143c1
Cr-Commit-Position: refs/heads/master@{#37974}
==========

[commit-bot: I haz the power, 2016-07-22 09:52:39]

Patchset 2 (id:??) landed as
https://crrev.com/428dde9ac79e3baead2e1cd384dfeab23de143c1
Cr-Commit-Position: refs/heads/master@{#37974}