Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 217653002: Cleanup changes in gcm_network_channel (Closed)

Created:
6 years, 8 months ago by pavely
Modified:
6 years, 8 months ago
Reviewers:
rlarocque
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Cleanup changes in gcm_network_channel No functionality change, just moving things around. - Move functions so that it is more convenient to read .cc file top to bottom. - replace ANDROID with OS_ANDROID. Looking at other places in the code OS_ANDROID is much more popular way to check for android. R=rlarocque@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260357

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -117 lines) Patch
M sync/notifier/gcm_network_channel.cc View 8 chunks +102 lines, -103 lines 0 comments Download
M sync/notifier/gcm_network_channel_unittest.cc View 2 chunks +12 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
pavely
6 years, 8 months ago (2014-03-28 21:58:36 UTC) #1
rlarocque
I didn't look closely at the changes, since I'm assuming based on the CL descriptions ...
6 years, 8 months ago (2014-03-28 22:02:31 UTC) #2
pavely
The CQ bit was checked by pavely@chromium.org
6 years, 8 months ago (2014-03-28 22:25:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/217653002/1
6 years, 8 months ago (2014-03-28 22:27:06 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 00:49:50 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-03-29 00:49:51 UTC) #6
pavely
The CQ bit was checked by pavely@chromium.org
6 years, 8 months ago (2014-03-29 00:51:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/217653002/1
6 years, 8 months ago (2014-03-29 00:52:12 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 02:25:46 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-29 02:25:48 UTC) #10
pavely
The CQ bit was checked by pavely@chromium.org
6 years, 8 months ago (2014-03-29 02:43:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/217653002/1
6 years, 8 months ago (2014-03-29 02:43:36 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-03-29 04:14:03 UTC) #13
Message was sent while issue was closed.
Change committed as 260357

Powered by Google App Engine
This is Rietveld 408576698