Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2176523003: FrameView shouldn't apply scroll anchoring when root layer scrolling is enabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index 687b58d8451b0789bb81f5d439dc29cfbdc80004..ee1ca3f5c889c21117b7941fad2247a4800cc04e 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -828,6 +828,14 @@ void FrameView::performPreLayoutTasks()
m_scrollAnchor.save();
}
+bool FrameView::shouldPerformScrollAnchoring() const
+{
+ return RuntimeEnabledFeatures::scrollAnchoringEnabled()
+ && m_frame->settings() && !m_frame->settings()->rootLayerScrolls()
+ && m_scrollAnchor.hasScroller()
+ && layoutBox()->style()->overflowAnchor() != AnchorNone;
+}
+
static inline void layoutFromRootObject(LayoutObject& root)
{
LayoutState layoutState(root);
@@ -3655,7 +3663,7 @@ void FrameView::adjustScrollPositionFromUpdateScrollbars()
// Restore before clamping because clamping clears the scroll anchor.
// TODO(ymalik): This same logic exists in PaintLayerScrollableArea.
// Remove when root-layer-scrolls is enabled.
- if (clamped != scrollPositionDouble() && shouldPerformScrollAnchoring() && m_scrollAnchor.hasScroller()) {
+ if (clamped != scrollPositionDouble() && shouldPerformScrollAnchoring()) {
m_scrollAnchor.restore();
clamped = clampScrollPosition(scrollPositionDouble());
}

Powered by Google App Engine
This is Rietveld 408576698