Intercept iTunes links and open iTunes controller.

Intercept iTunes links and open iTunes controller.

The goal of this CL is to workaround a bug where Apple serves the
wrong content for itunes.apple.com pages, see the associated bug
report.

This CL adds a class that observe navigation events.
If a page concerning a product on the iTunes App Store is *loaded*,
this class triggers the opening of a SKStoreProductViewController
presenting the information of the said product.
If Apple fixes what the server serves, than the iTunes App Store
pages won't ever be loaded: the users will be automatically offered to
open the App Store application.

BUG=623016
Committed: https://crrev.com/aea5f5e7e1152f988059835305d4a996533160cc
Cr-Commit-Position: refs/heads/master@{#407467}

[jif-google, 2016-07-22 09:15:07]

The CQ bit was checked by jif@google.com to run a CQ dry run

[jif-google, 2016-07-22 09:15:15]

Description was changed from

==========
Intercept iTunes links and open iTunes controller.

The goal of this CL is to workaround a bug where Apple serves the wrong
content for itunes.apple.com pages, see the associated bug report.

This CL adds a class that observe navigation events.
If a page concerning a product on the iTunes App Store is *loaded*,
this class
triggers the opening of a SKStoreProductViewController presenting
the information of the said product.
If Apple fixes what the server serves, than the iTunes App Store
pages won't ever be loaded: the users will be automatically offered to
open the App Store application.
This is what currently happens on iPhone (even with this patch applied).

BUG=623016
==========

to

==========
Intercept iTunes links and open iTunes controller.

The goal of this CL is to workaround a bug where Apple serves the wrong
content for itunes.apple.com pages, see the associated bug report.

This CL adds a class that observe navigation events.
If a page concerning a product on the iTunes App Store is *loaded*,
this class
triggers the opening of a SKStoreProductViewController presenting
the information of the said product.
If Apple fixes what the server serves, than the iTunes App Store
pages won't ever be loaded: the users will be automatically offered to
open the App Store application.
This is what currently happens on iPhone (even with this patch applied).

BUG=623016
==========

[commit-bot: I haz the power, 2016-07-22 09:15:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jif, 2016-07-22 09:16:06]

jif@chromium.org changed reviewers:
+ sdefresne@chromium.org
- jif@google.com

[jif, 2016-07-22 09:17:30]

ptal.

I got all the necessary LGTM in a downstream CL:
https://chromereviews.googleplex.com/467197014/

[commit-bot: I haz the power, 2016-07-22 09:22:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 09:22:25]

Dry run: Try jobs failed on following builders:
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[jif, 2016-07-22 11:18:49]

Description was changed from

==========
Intercept iTunes links and open iTunes controller.

The goal of this CL is to workaround a bug where Apple serves the wrong
content for itunes.apple.com pages, see the associated bug report.

This CL adds a class that observe navigation events.
If a page concerning a product on the iTunes App Store is *loaded*,
this class
triggers the opening of a SKStoreProductViewController presenting
the information of the said product.
If Apple fixes what the server serves, than the iTunes App Store
pages won't ever be loaded: the users will be automatically offered to
open the App Store application.
This is what currently happens on iPhone (even with this patch applied).

BUG=623016
==========

to

==========
Intercept iTunes links and open iTunes controller.

The goal of this CL is to workaround a bug where Apple serves the wrong content
for itunes.apple.com pages, see the associated bug
report.

This CL adds a class that observe navigation events.
If a page concerning a product on the iTunes App Store is *loaded*,
this class triggers the opening of a SKStoreProductViewController
presenting the information of the said product.
If Apple fixes what the server serves, than the iTunes App Store
pages won't ever be loaded: the users will be automatically offered to
open the App Store application.

BUG=623016
==========

[jif, 2016-07-22 11:18:58]

Description was changed from

==========
Intercept iTunes links and open iTunes controller.

The goal of this CL is to workaround a bug where Apple serves the wrong content
for itunes.apple.com pages, see the associated bug
report.

This CL adds a class that observe navigation events.
If a page concerning a product on the iTunes App Store is *loaded*,
this class triggers the opening of a SKStoreProductViewController
presenting the information of the said product.
If Apple fixes what the server serves, than the iTunes App Store
pages won't ever be loaded: the users will be automatically offered to
open the App Store application.

BUG=623016
==========

to

==========
Intercept iTunes links and open iTunes controller.

The goal of this CL is to workaround a bug where Apple serves the
wrong content for itunes.apple.com pages, see the associated bug
report.

This CL adds a class that observe navigation events.
If a page concerning a product on the iTunes App Store is *loaded*,
this class triggers the opening of a SKStoreProductViewController
presenting the information of the said product.
If Apple fixes what the server serves, than the iTunes App Store
pages won't ever be loaded: the users will be automatically offered to
open the App Store application.

BUG=623016
==========

[jif, 2016-07-25 08:53:44]

ping

[sdefresne, 2016-07-25 12:05:37]

lgtm

https://codereview.chromium.org/2176503003/diff/20001/ios/chrome/browser/itun...
File ios/chrome/browser/itunes_links/itunes_links_observer.h (right):

https://codereview.chromium.org/2176503003/diff/20001/ios/chrome/browser/itun...
ios/chrome/browser/itunes_links/itunes_links_observer.h:23: // content for
itunes.apple.com pages, see crbug.com/623016.
nit: http://crbug.com/623016

https://codereview.chromium.org/2176503003/diff/20001/ios/chrome/browser/itun...
File ios/chrome/browser/itunes_links/itunes_links_observer.mm (right):

https://codereview.chromium.org/2176503003/diff/20001/ios/chrome/browser/itun...
ios/chrome/browser/itunes_links/itunes_links_observer.mm:10: #include
"base/mac/scoped_nsobject.h"
#import

[jif, 2016-07-25 12:58:27]

thanks

https://codereview.chromium.org/2176503003/diff/20001/ios/chrome/browser/itun...
File ios/chrome/browser/itunes_links/itunes_links_observer.h (right):

https://codereview.chromium.org/2176503003/diff/20001/ios/chrome/browser/itun...
ios/chrome/browser/itunes_links/itunes_links_observer.h:23: // content for
itunes.apple.com pages, see crbug.com/623016.
On 2016/07/25 12:05:37, sdefresne wrote:
> nit: http://crbug.com/623016

Done.

https://codereview.chromium.org/2176503003/diff/20001/ios/chrome/browser/itun...
File ios/chrome/browser/itunes_links/itunes_links_observer.mm (right):

https://codereview.chromium.org/2176503003/diff/20001/ios/chrome/browser/itun...
ios/chrome/browser/itunes_links/itunes_links_observer.mm:10: #include
"base/mac/scoped_nsobject.h"
On 2016/07/25 12:05:37, sdefresne wrote:
> #import

Done.

[jif, 2016-07-25 12:58:31]

The CQ bit was checked by jif@chromium.org

[jif, 2016-07-25 12:58:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2176503003/#ps40001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2016-07-25 12:58:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 13:55:21]

Description was changed from

==========
Intercept iTunes links and open iTunes controller.

The goal of this CL is to workaround a bug where Apple serves the
wrong content for itunes.apple.com pages, see the associated bug
report.

This CL adds a class that observe navigation events.
If a page concerning a product on the iTunes App Store is *loaded*,
this class triggers the opening of a SKStoreProductViewController
presenting the information of the said product.
If Apple fixes what the server serves, than the iTunes App Store
pages won't ever be loaded: the users will be automatically offered to
open the App Store application.

BUG=623016
==========

to

==========
Intercept iTunes links and open iTunes controller.

The goal of this CL is to workaround a bug where Apple serves the
wrong content for itunes.apple.com pages, see the associated bug
report.

This CL adds a class that observe navigation events.
If a page concerning a product on the iTunes App Store is *loaded*,
this class triggers the opening of a SKStoreProductViewController
presenting the information of the said product.
If Apple fixes what the server serves, than the iTunes App Store
pages won't ever be loaded: the users will be automatically offered to
open the App Store application.

BUG=623016
==========

[commit-bot: I haz the power, 2016-07-25 13:55:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-25 13:56:41]

Description was changed from

==========
Intercept iTunes links and open iTunes controller.

The goal of this CL is to workaround a bug where Apple serves the
wrong content for itunes.apple.com pages, see the associated bug
report.

This CL adds a class that observe navigation events.
If a page concerning a product on the iTunes App Store is *loaded*,
this class triggers the opening of a SKStoreProductViewController
presenting the information of the said product.
If Apple fixes what the server serves, than the iTunes App Store
pages won't ever be loaded: the users will be automatically offered to
open the App Store application.

BUG=623016
==========

to

==========
Intercept iTunes links and open iTunes controller.

The goal of this CL is to workaround a bug where Apple serves the
wrong content for itunes.apple.com pages, see the associated bug
report.

This CL adds a class that observe navigation events.
If a page concerning a product on the iTunes App Store is *loaded*,
this class triggers the opening of a SKStoreProductViewController
presenting the information of the said product.
If Apple fixes what the server serves, than the iTunes App Store
pages won't ever be loaded: the users will be automatically offered to
open the App Store application.

BUG=623016

Committed: https://crrev.com/aea5f5e7e1152f988059835305d4a996533160cc
Cr-Commit-Position: refs/heads/master@{#407467}
==========

[commit-bot: I haz the power, 2016-07-25 13:56:42]

Patchset 3 (id:??) landed as
https://crrev.com/aea5f5e7e1152f988059835305d4a996533160cc
Cr-Commit-Position: refs/heads/master@{#407467}