Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2176473002: X87: [fullcodegen] [crankshaft] Avoid jumping to the runtime for ForInFilter. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [fullcodegen] [crankshaft] Avoid jumping to the runtime for ForInFilter. port 4b59bf53139f7c7a2c9b105d90f1bbd4c0c0150e (r37934) original commit message: Use the ForInFilterStub directly. Hence we will only jump to the runtime for special receivers (instance_type <= LAST_SPECIAL_RECEIVER_TYPE) and for converting element indices which are not in the string cache. BUG= Committed: https://crrev.com/abff40a485b3af1789cd9ad25ec30da1deb6e959 Cr-Commit-Position: refs/heads/master@{#37963}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 3 chunks +13 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-07-22 02:11:33 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-07-22 02:18:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176473002/1
4 years, 5 months ago (2016-07-22 02:50:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 03:10:39 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 03:13:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/abff40a485b3af1789cd9ad25ec30da1deb6e959
Cr-Commit-Position: refs/heads/master@{#37963}

Powered by Google App Engine
This is Rietveld 408576698