Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2176433002: Fix //components/drive:drive_chromeos to only be defined on CrOS in GN. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix //components/drive:drive_chromeos to only be defined on CrOS in GN. TBR=brettw@chromium.org NOTRY=true NOTREECHECKS=true BUG=627637 Committed: https://crrev.com/79f7b784a97cbb22f11064a05b621b0def87eab3 Cr-Commit-Position: refs/heads/master@{#407004}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -70 lines) Patch
M components/drive/BUILD.gn View 2 chunks +69 lines, -70 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176433002/1
4 years, 5 months ago (2016-07-22 00:49:58 UTC) #3
Dirk Pranke
TBR/NOTRY/NOTREECHECKS as a build fix.
4 years, 5 months ago (2016-07-22 00:50:25 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 00:56:10 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 00:57:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79f7b784a97cbb22f11064a05b621b0def87eab3
Cr-Commit-Position: refs/heads/master@{#407004}

Powered by Google App Engine
This is Rietveld 408576698