Issue 217643003: Revert of MemoryCache: make sure that Resources are evicted only when they can be deleted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 217643003: Revert of MemoryCache: make sure that Resources are evicted only when they can be deleted (Closed)

Created:
6 years, 9 months ago by enne (OOO)

Modified:
6 years, 9 months ago

Reviewers:
eustas, Philippe, clamy, Nate Chapin

CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Revert of MemoryCache: make sure that Resources are evicted only when they can be deleted (https://codereview.chromium.org/179943002/) Reason for revert: Possibly causing crashes in MultiProfileFileManagerBrowserTest See: http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/7766 Original issue's description: > MemoryCache: make sure that Resources are evicted only when they can be deleted > > This CL fixes a problem where Resources can be taken out of the cache but not > deleted (if their handle count is not 0 for example). > > BUG=290193 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170311 TBR=pliard@chromium.org,japhet@chromium.org,eustas@chromium.org,clamy@chromium.org NOTREECHECKS=true NOTRY=true BUG=290193 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170380

Created: 6 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -38 lines)			Patch
M	Source/core/fetch/MemoryCache.cpp	View	2 chunks	+4 lines, -7 lines	0 comments	Download
M	Source/core/fetch/MemoryCacheTest.cpp	View	6 chunks	+7 lines, -8 lines	0 comments	Download
M	Source/core/fetch/Resource.h	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	Source/core/fetch/Resource.cpp	View	3 chunks	+0 lines, -18 lines	0 comments	Download
M	Source/core/fetch/ResourceFetcher.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

enne (OOO)

Created Revert of MemoryCache: make sure that Resources are evicted only when they can be ...

6 years, 9 months ago (2014-03-28 23:21:16 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/217643003/1

6 years, 9 months ago (2014-03-28 23:21:26 UTC) #2

Message was sent while issue was closed.

Change committed as 170380