Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2176413003: DBC: Fix reading locals out of a deopt frame. (Closed)

Created:
4 years, 4 months ago by rmacnak
Modified:
4 years, 4 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -17 lines) Patch
M runtime/tests/vm/vm.status View 2 chunks +0 lines, -7 lines 0 comments Download
M runtime/vm/constants_dbc.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/debugger.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stack_frame.h View 1 3 chunks +11 lines, -2 lines 0 comments Download
M runtime/vm/stack_frame.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M runtime/vm/stack_frame_dbc.h View 1 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rmacnak
https://codereview.chromium.org/2176413003/diff/1/runtime/vm/stack_frame_dbc.h File runtime/vm/stack_frame_dbc.h (right): https://codereview.chromium.org/2176413003/diff/1/runtime/vm/stack_frame_dbc.h#newcode64 runtime/vm/stack_frame_dbc.h:64: return fp - (index + 1) * kWordSize; Not ...
4 years, 4 months ago (2016-07-26 16:21:06 UTC) #2
zra
https://codereview.chromium.org/2176413003/diff/1/runtime/vm/stack_frame_dbc.h File runtime/vm/stack_frame_dbc.h (right): https://codereview.chromium.org/2176413003/diff/1/runtime/vm/stack_frame_dbc.h#newcode59 runtime/vm/stack_frame_dbc.h:59: DART_FORCE_INLINE static uword LocalVarAddress(uword fp, intptr_t index) { Can ...
4 years, 4 months ago (2016-07-26 16:35:50 UTC) #3
rmacnak
https://codereview.chromium.org/2176413003/diff/1/runtime/vm/stack_frame_dbc.h File runtime/vm/stack_frame_dbc.h (right): https://codereview.chromium.org/2176413003/diff/1/runtime/vm/stack_frame_dbc.h#newcode59 runtime/vm/stack_frame_dbc.h:59: DART_FORCE_INLINE static uword LocalVarAddress(uword fp, intptr_t index) { On ...
4 years, 4 months ago (2016-07-26 17:22:23 UTC) #4
zra
lgtm
4 years, 4 months ago (2016-07-26 17:32:20 UTC) #5
rmacnak
4 years, 4 months ago (2016-07-26 17:36:13 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
708334c6141162f60ea18e2aaa433c8b91300e1d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698