Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2176403002: Log when leaving main and list remaining threads in builder_alerts (Closed)

Created:
4 years, 5 months ago by Sergiy Byelozyorov
Modified:
4 years, 5 months ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Log when leaving main and list remaining threads in builder_alerts TBR=tandrii@chromium.org BUG=630891 Committed: https://chromium.googlesource.com/infra/infra/+/09f9cb9556e8d4de5e0103803324162f8387fb81

Patch Set 1 #

Patch Set 2 : Fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M infra/services/builder_alerts/__main__.py View 1 8 chunks +16 lines, -0 lines 1 comment Download
M infra/services/builder_alerts/alert_builder.py View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176403002/1
4 years, 5 months ago (2016-07-25 22:45:28 UTC) #2
Sergiy Byelozyorov
4 years, 5 months ago (2016-07-25 22:45:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176403002/20001
4 years, 5 months ago (2016-07-25 22:58:38 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/infra/infra/+/09f9cb9556e8d4de5e0103803324162f8387fb81
4 years, 5 months ago (2016-07-25 23:18:16 UTC) #8
tandrii(chromium)
4 years, 5 months ago (2016-07-26 09:56:35 UTC) #9
Message was sent while issue was closed. 
PLEASE FIX.

https://codereview.chromium.org/2176403002/diff/20001/infra/services/builder_...
File infra/services/builder_alerts/__main__.py (right):

https://codereview.chromium.org/2176403002/diff/20001/infra/services/builder_...
infra/services/builder_alerts/__main__.py:456: current_thread_descriptions =
[t.name + (' (daemon)' if t.isDaemon() else '')
this will never be executed. sys.exit raises SystemExit exception.

Powered by Google App Engine
This is Rietveld 408576698