Add expiration policy, code to check it, and a test.

Add expiration policy, code to check it, and a test.

BUG=610521
Committed: https://crrev.com/e5a3ddef4de9eb3d1ddf3d8bae1994c810b82b98
Cr-Commit-Position: refs/heads/master@{#408202}

[Pete Williamson, 2016-07-27 00:30:17]

petewil@chromium.org changed reviewers:
+ dougarnett@chromium.org

[dougarnett, 2016-07-27 15:40:41]

https://codereview.chromium.org/2176393004/diff/1/components/offline_pages/ba...
File components/offline_pages/background/request_picker.cc (right):

https://codereview.chromium.org/2176393004/diff/1/components/offline_pages/ba...
components/offline_pages/background/request_picker.cc:121: return false;
Maybe add TODO wrt need to remove this from the queue somehow

https://codereview.chromium.org/2176393004/diff/1/components/offline_pages/ba...
File components/offline_pages/background/request_picker_unittest.cc (right):

https://codereview.chromium.org/2176393004/diff/1/components/offline_pages/ba...
components/offline_pages/background/request_picker_unittest.cc:267: 
remove extra blank line

[dougarnett, 2016-07-27 15:45:13]

https://codereview.chromium.org/2176393004/diff/1/components/offline_pages/ba...
File components/offline_pages/background/offliner_policy.h (right):

https://codereview.chromium.org/2176393004/diff/1/components/offline_pages/ba...
components/offline_pages/background/offliner_policy.h:81: int
GetPageExpirationTimeInSeconds() const {
Actually seems to be "Request" expiration rather than "Page" expiration

[Pete Williamson, 2016-07-27 17:20:06]

https://codereview.chromium.org/2176393004/diff/1/components/offline_pages/ba...
File components/offline_pages/background/offliner_policy.h (right):

https://codereview.chromium.org/2176393004/diff/1/components/offline_pages/ba...
components/offline_pages/background/offliner_policy.h:81: int
GetPageExpirationTimeInSeconds() const {
On 2016/07/27 15:45:13, dougarnett wrote:
> Actually seems to be "Request" expiration rather than "Page" expiration

Done.

https://codereview.chromium.org/2176393004/diff/1/components/offline_pages/ba...
File components/offline_pages/background/request_picker.cc (right):

https://codereview.chromium.org/2176393004/diff/1/components/offline_pages/ba...
components/offline_pages/background/request_picker.cc:121: return false;
On 2016/07/27 15:40:41, dougarnett wrote:
> Maybe add TODO wrt need to remove this from the queue somehow

Done.

https://codereview.chromium.org/2176393004/diff/1/components/offline_pages/ba...
File components/offline_pages/background/request_picker_unittest.cc (right):

https://codereview.chromium.org/2176393004/diff/1/components/offline_pages/ba...
components/offline_pages/background/request_picker_unittest.cc:267: 
On 2016/07/27 15:40:41, dougarnett wrote:
> remove extra blank line

Done.

[dougarnett, 2016-07-27 17:43:16]

lgtm

[Pete Williamson, 2016-07-27 17:44:35]

The CQ bit was checked by petewil@chromium.org

[commit-bot: I haz the power, 2016-07-27 17:44:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 18:55:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-27 18:56:54]

Description was changed from

==========
Add expiration policy, code to check it, and a test.

BUG=610521
==========

to

==========
Add expiration policy, code to check it, and a test.

BUG=610521

Committed: https://crrev.com/e5a3ddef4de9eb3d1ddf3d8bae1994c810b82b98
Cr-Commit-Position: refs/heads/master@{#408202}
==========

[commit-bot: I haz the power, 2016-07-27 18:56:55]

Patchset 2 (id:??) landed as
https://crrev.com/e5a3ddef4de9eb3d1ddf3d8bae1994c810b82b98
Cr-Commit-Position: refs/heads/master@{#408202}