Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2176393003: [heap] ObjectStats: Account for headers when computing HashTable overhead (Closed)

Created:
4 years, 4 months ago by Michael Lippautz
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] ObjectStats: Account for headers when computing HashTable overhead BUG=chromium:631094 R=hpayer@chromium.org Committed: https://crrev.com/038bafcabf19c46d2d0f8560bd046ae297ef5004 Cr-Commit-Position: refs/heads/master@{#38072}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M src/heap/object-stats.cc View 3 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Lippautz
4 years, 4 months ago (2016-07-26 18:22:03 UTC) #1
Hannes Payer (out of office)
lgtm
4 years, 4 months ago (2016-07-26 20:04:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176393003/1
4 years, 4 months ago (2016-07-26 20:04:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 20:32:45 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 20:34:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/038bafcabf19c46d2d0f8560bd046ae297ef5004
Cr-Commit-Position: refs/heads/master@{#38072}

Powered by Google App Engine
This is Rietveld 408576698