Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2176373004: [DevTools] Speculative crash fix in currentCallFrames (Closed)

Created:
4 years, 5 months ago by kozy
Modified:
4 years, 4 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Speculative crash fix in currentCallFrames Probably break can be scheduled in DevTools and then callback can be accidently called when debugger has already disabled. Additionally, added one more assert tp check that there is no problem with debugger script compilation. BUG=611331 R=dgozman@chromium.org Committed: https://crrev.com/82b1f73e4495380d2777480a8a0087974732ee80 Cr-Commit-Position: refs/heads/master@{#407904}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
kozy
Dmitry, please take a look!
4 years, 5 months ago (2016-07-26 02:10:18 UTC) #1
dgozman
lgtm
4 years, 4 months ago (2016-07-26 19:17:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176373004/1
4 years, 4 months ago (2016-07-26 20:30:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 20:35:12 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 20:36:33 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82b1f73e4495380d2777480a8a0087974732ee80
Cr-Commit-Position: refs/heads/master@{#407904}

Powered by Google App Engine
This is Rietveld 408576698