Removed io dependencies in analyzer to allow compiler to run in the browser

Removed io dependencies in analyzer to allow compiler to run in the browser

BUG=
R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/9fa7b5effef3291fe0a6bdd049fd68203a40484f

[priscillalee, 2016-07-25 22:08:54]

priscillalee@google.com changed reviewers:
+ jmesserly@google.com

[priscillalee, 2016-07-25 22:08:55]

Hey John, could you take a look at the changes I made and help me figure out how
I can get them refactored into the analyzer and who I should contact? Thanks.

[Jennifer Messerly, 2016-07-25 22:57:50]

jmesserly@google.com changed reviewers:
+ paulberry@google.com

[Jennifer Messerly, 2016-07-25 22:57:50]

Hey Paul -- do you know what would be the best way to follow up on this?

We wanted to host DDC in the browser (Dartium & dart2js), which required
removing "dart:io" dependencies, and allowing the SDK summary to be loaded from
bytes (otherwise it used file IO internally).

[priscillalee, 2016-07-26 21:00:44]

Returned io dependencies (because they work in dart2js) and minimized number of
changes made to analyzer.

[Paul Berry, 2016-07-26 21:16:22]

https://codereview.chromium.org/2176363002/diff/180001/pkg/analyzer/lib/src/s...
File pkg/analyzer/lib/src/summary/package_bundle_reader.dart (right):

https://codereview.chromium.org/2176363002/diff/180001/pkg/analyzer/lib/src/s...
pkg/analyzer/lib/src/summary/package_bundle_reader.dart:277:
SummaryDataStore(Iterable<String> summaryPaths, [PackageBundle bundle]) {
These changes shouldn't be necessary--the caller should just call addBundle (see
suggestion below).

https://codereview.chromium.org/2176363002/diff/180001/pkg/analyzer/lib/src/s...
File pkg/analyzer/lib/src/summary/summary_sdk.dart (right):

https://codereview.chromium.org/2176363002/diff/180001/pkg/analyzer/lib/src/s...
pkg/analyzer/lib/src/summary/summary_sdk.dart:117: SummaryBasedDartSdk(String
summaryPath, this.strongMode,
Rather than have one constructor with two different behaviors (and two different
sets of arguments it pays attention to), leave this constructor as is, and just
make a new constructor, e.g.:

SummaryBasedDartSdk.fromBundle(this.strongMode, PackageBundle bundle,
this.resourceProvider) {
  _dataStore = new SummaryDataStore([]);
  _dataStore.addBundle(bundle);
  _uriResolver = ...;
  _bundle = bundle;
}

That way there's no danger of callers accidentally mixing and matching the two
calling styles and getting nonsense results.

[priscillalee, 2016-07-26 21:32:48]

Thanks for the review. Made the suggested changes.

https://codereview.chromium.org/2176363002/diff/180001/pkg/analyzer/lib/src/s...
File pkg/analyzer/lib/src/summary/package_bundle_reader.dart (right):

https://codereview.chromium.org/2176363002/diff/180001/pkg/analyzer/lib/src/s...
pkg/analyzer/lib/src/summary/package_bundle_reader.dart:277:
SummaryDataStore(Iterable<String> summaryPaths, [PackageBundle bundle]) {
On 2016/07/26 21:16:22, Paul Berry wrote:
> These changes shouldn't be necessary--the caller should just call addBundle
(see
> suggestion below).

Done.

https://codereview.chromium.org/2176363002/diff/180001/pkg/analyzer/lib/src/s...
File pkg/analyzer/lib/src/summary/summary_sdk.dart (right):

https://codereview.chromium.org/2176363002/diff/180001/pkg/analyzer/lib/src/s...
pkg/analyzer/lib/src/summary/summary_sdk.dart:117: SummaryBasedDartSdk(String
summaryPath, this.strongMode,
On 2016/07/26 21:16:22, Paul Berry wrote:
> Rather than have one constructor with two different behaviors (and two
different
> sets of arguments it pays attention to), leave this constructor as is, and
just
> make a new constructor, e.g.:
> 
> SummaryBasedDartSdk.fromBundle(this.strongMode, PackageBundle bundle,
> this.resourceProvider) {
>   _dataStore = new SummaryDataStore([]);
>   _dataStore.addBundle(bundle);
>   _uriResolver = ...;
>   _bundle = bundle;
> }
> 
> That way there's no danger of callers accidentally mixing and matching the two
> calling styles and getting nonsense results.

Done.

[Paul Berry, 2016-07-26 21:51:52]

lgtm

[priscillalee, 2016-07-26 23:38:02]

Thanks Paul! Just updated the analyzer version and added changelog comments.

[priscillalee, 2016-07-26 23:43:41]

Description was changed from

==========
Removed io dependencies in analyzer to allow compiler to run in the browser

BUG=
==========

to

==========
Removed io dependencies in analyzer to allow compiler to run in the browser

BUG=
R=paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9fa7b5effef3291fe0a6bdd049fd68203a40484f
==========

[priscillalee, 2016-07-26 23:43:42]

Committed patchset #12 (id:220001) manually as
9fa7b5effef3291fe0a6bdd049fd68203a40484f (presubmit successful).