Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2176343006: [LayoutNG] Add NGConstraintSpace class definition (Closed)

Created:
4 years, 4 months ago by eae
Modified:
4 years, 4 months ago
Reviewers:
ikilpatrick
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Add NGConstraintSpace class definition Define initial outline of the constraint space API for LayoutNG by means of the NG[Derived]ConstraintSpace & NGLayoutOpportunityIterator classes. BUG=591099 R=ikilpatrick@chromium.org Committed: https://crrev.com/d32fdb7a2428764717bddae953628b07eba2afdd Cr-Commit-Position: refs/heads/master@{#409035}

Patch Set 1 #

Total comments: 14

Patch Set 2 : Address reviewer comments #

Patch Set 3 : Add NGLayoutOpportunityIterator #

Total comments: 9

Patch Set 4 : test #

Patch Set 5 : Rebase w/HEAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -0 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h View 1 2 3 1 chunk +150 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.cpp View 1 2 3 4 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (17 generated)
ikilpatrick
https://codereview.chromium.org/2176343006/diff/1/third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h File third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h (right): https://codereview.chromium.org/2176343006/diff/1/third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h#newcode16 third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h:16: class PLATFORM_EXPORT NGConstraintSpace { CORE_EXPORT:) https://codereview.chromium.org/2176343006/diff/1/third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h#newcode16 third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h:16: class PLATFORM_EXPORT ...
4 years, 4 months ago (2016-07-27 21:14:12 UTC) #1
eae
Thanks! https://codereview.chromium.org/2176343006/diff/1/third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h File third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h (right): https://codereview.chromium.org/2176343006/diff/1/third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h#newcode16 third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h:16: class PLATFORM_EXPORT NGConstraintSpace { On 2016/07/27 21:14:12, ikilpatrick ...
4 years, 4 months ago (2016-07-27 21:24:16 UTC) #2
ikilpatrick
Broadly lgtm. We can polish/fixup as required. https://codereview.chromium.org/2176343006/diff/60001/third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h File third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h (right): https://codereview.chromium.org/2176343006/diff/60001/third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h#newcode19 third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h:19: enum NGClearExclusion ...
4 years, 4 months ago (2016-07-29 17:18:44 UTC) #13
eae
Thanks! https://codereview.chromium.org/2176343006/diff/60001/third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h File third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h (right): https://codereview.chromium.org/2176343006/diff/60001/third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h#newcode19 third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h:19: enum NGClearExclusion { On 2016/07/29 17:18:44, ikilpatrick wrote: ...
4 years, 4 months ago (2016-07-29 17:41:02 UTC) #14
ikilpatrick
https://codereview.chromium.org/2176343006/diff/60001/third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h File third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h (right): https://codereview.chromium.org/2176343006/diff/60001/third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h#newcode136 third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h:136: // resolution to work correctly. On 2016/07/29 17:41:02, eae ...
4 years, 4 months ago (2016-07-29 19:15:01 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176343006/80001
4 years, 4 months ago (2016-08-01 16:07:13 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/210449)
4 years, 4 months ago (2016-08-01 16:16:02 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176343006/100001
4 years, 4 months ago (2016-08-01 18:24:39 UTC) #23
commit-bot: I haz the power
Committed patchset #5 (id:100001)
4 years, 4 months ago (2016-08-01 20:00:54 UTC) #25
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 20:03:54 UTC) #27
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/d32fdb7a2428764717bddae953628b07eba2afdd
Cr-Commit-Position: refs/heads/master@{#409035}

Powered by Google App Engine
This is Rietveld 408576698