sync: Remove TrafficRecorder

sync: Remove TrafficRecorder

The new protocol events framework handles all the use cases of the
TrafficRecorder, and more.  The traffic recorder implementation and about:sync
tab are now redundant.

BUG=357821
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261032

[rlarocque, 2014-04-01 17:39:23]

Please review.

https://codereview.chromium.org/217633003/diff/1/build/ios/grit_whitelist.txt
File build/ios/grit_whitelist.txt (left):

https://codereview.chromium.org/217633003/diff/1/build/ios/grit_whitelist.txt...
build/ios/grit_whitelist.txt:56: IDR_SYNC_INTERNALS_NOTIFICATIONS_JS
I don't know what this file does, but I assume these entries are no longer
needed.

[James Hawkins, 2014-04-01 18:12:51]

Which files are you asking me to review?

[rlarocque, 2014-04-01 18:18:12]

On 2014/04/01 18:12:51, James Hawkins wrote:
> Which files are you asking me to review?

Sorry, forgot to mention that.

jhawkins: Please review the changes in chrome/browser/ui/webui and
chrome/browser/resources.

I think Tim is an OWNER for everything else, so he can review the rest of it.

[James Hawkins, 2014-04-01 18:28:00]

lgtm

[tim (not reviewing), 2014-04-01 20:16:57]

On 2014/04/01 18:28:00, James Hawkins wrote:
> lgtm

lgtm

[rlarocque, 2014-04-01 20:17:46]

The CQ bit was checked by rlarocque@chromium.org

[commit-bot: I haz the power, 2014-04-01 20:24:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rlarocque@chromium.org/217633003/1

[commit-bot: I haz the power, 2014-04-01 20:24:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-01 20:24:53]

Failed to apply patch for sync/internal_api/sync_manager_impl.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file sync/internal_api/sync_manager_impl.h
  Hunk #2 succeeded at 275 (offset 3 lines).
  Hunk #3 FAILED at 356.
  1 out of 3 hunks FAILED -- saving rejects to file
sync/internal_api/sync_manager_impl.h.rej

Patch:       sync/internal_api/sync_manager_impl.h
Index: sync/internal_api/sync_manager_impl.h
diff --git a/sync/internal_api/sync_manager_impl.h
b/sync/internal_api/sync_manager_impl.h
index
5cb39088b73e843b6922384523f93e215088d0ef..311e162974d3549e30959f18d40542cadbc9a029
100644
--- a/sync/internal_api/sync_manager_impl.h
+++ b/sync/internal_api/sync_manager_impl.h
@@ -13,7 +13,6 @@
 #include "sync/engine/all_status.h"
 #include "sync/engine/net/server_connection_manager.h"
 #include "sync/engine/sync_engine_event_listener.h"
-#include "sync/engine/traffic_recorder.h"
 #include "sync/internal_api/change_reorder_buffer.h"
 #include "sync/internal_api/debug_info_event_listener.h"
 #include "sync/internal_api/js_mutation_event_observer.h"
@@ -273,7 +272,6 @@ class SYNC_EXPORT_PRIVATE SyncManagerImpl :
   JsArgList GetNodeSummariesById(const JsArgList& args);
   JsArgList GetNodeDetailsById(const JsArgList& args);
   JsArgList GetChildNodeIds(const JsArgList& args);
-  JsArgList GetClientServerTraffic(const JsArgList& args);
 
   syncable::Directory* directory();
 
@@ -358,8 +356,6 @@ class SYNC_EXPORT_PRIVATE SyncManagerImpl :
   // This is for keeping track of client events to send to the server.
   DebugInfoEventListener debug_info_event_listener_;
 
-  TrafficRecorder traffic_recorder_;
-
   Encryptor* encryptor_;
   scoped_ptr<UnrecoverableErrorHandler> unrecoverable_error_handler_;
   ReportUnrecoverableErrorFunction report_unrecoverable_error_function_;

[rlarocque, 2014-04-01 22:20:50]

The CQ bit was checked by rlarocque@chromium.org

[commit-bot: I haz the power, 2014-04-01 22:49:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rlarocque@chromium.org/217633003/20001

[commit-bot: I haz the power, 2014-04-02 01:48:09]

Change committed as 261032