Deprecate FLAGS_quic_disable_pre_30. Remove QUIC versions [25-29].

net/tools/quic/quic_dispatcher.cc

Index: net/tools/quic/quic_dispatcher.cc
diff --git a/net/tools/quic/quic_dispatcher.cc b/net/tools/quic/quic_dispatcher.cc
index 25b1bdfe31ef5d73761b975892df70593aa936e0..fe8ccb62243d612d80382c07aa3ab810218bd482 100644
--- a/net/tools/quic/quic_dispatcher.cc
+++ b/net/tools/quic/quic_dispatcher.cc
@@ -202,7 +202,6 @@ QuicDispatcher::QuicDispatcher(
           alarm_factory_->CreateAlarm(new DeleteSessionsAlarm(this))),
       buffered_packets_(this, helper_->GetClock(), alarm_factory_.get()),
       supported_versions_(supported_versions),
-      disable_quic_pre_30_(FLAGS_quic_disable_pre_30),
       allowed_supported_versions_(supported_versions),
       current_packet_(nullptr),
       framer_(supported_versions,
@@ -741,10 +740,9 @@ QuicDispatcher::QuicPacketFate QuicDispatcher::MaybeRejectStatelessly(
 
 const QuicVersionVector& QuicDispatcher::GetSupportedVersions() {
   // Filter (or un-filter) the list of supported versions based on the flag.
-  if (disable_quic_pre_30_ != FLAGS_quic_disable_pre_30) {
+  if (false) {
     DCHECK_EQ(supported_versions_.capacity(),
               allowed_supported_versions_.capacity());
-    disable_quic_pre_30_ = FLAGS_quic_disable_pre_30;
     supported_versions_ = FilterSupportedVersions(allowed_supported_versions_);
   }

[Zhongyi Shi, 2016/07/25 22:52:49]

nit: though this looks consistent with the internal CL. But out of curiosity,
why do we have this chunk of code left here?

[Ryan Hamilton, 2016/07/25 23:07:34]

'cause this code is going to come back RSN with v35 and v36. (Fan is working on
this). But yeah. This is warty.

   return supported_versions_;