Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/quic/crypto/proof_verifier_chromium_test.cc

Issue 2176323002: Deprecate FLAGS_quic_disable_pre_30. Remove QUIC versions [25-29]. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@127879468
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/crypto/crypto_server_test.cc ('k') | net/quic/crypto/quic_crypto_client_config.cc » ('j') | net/tools/quic/quic_dispatcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/crypto/proof_verifier_chromium_test.cc
diff --git a/net/quic/crypto/proof_verifier_chromium_test.cc b/net/quic/crypto/proof_verifier_chromium_test.cc
index fff1bf6d6b28203273945d02f028c67b126e1b39..2e3e28195c20052e9bf8a09d898d24b653b1090c 100644
--- a/net/quic/crypto/proof_verifier_chromium_test.cc
+++ b/net/quic/crypto/proof_verifier_chromium_test.cc
@@ -231,7 +231,7 @@ TEST_F(ProofVerifierChromiumTest, FailsIfCertFails) {
std::unique_ptr<DummyProofVerifierCallback> callback(
new DummyProofVerifierCallback);
QuicAsyncStatus status = proof_verifier.VerifyProof(
- kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_, "",
+ kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, "", certs_, "",
GetTestSignature(), verify_context_.get(), &error_details_, &details_,
std::move(callback));
ASSERT_EQ(QUIC_FAILURE, status);
@@ -250,7 +250,7 @@ TEST_F(ProofVerifierChromiumTest, ValidSCTList) {
std::unique_ptr<DummyProofVerifierCallback> callback(
new DummyProofVerifierCallback);
QuicAsyncStatus status = proof_verifier.VerifyProof(
- kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_,
+ kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, "", certs_,
ct::GetSCTListForTesting(), "", verify_context_.get(), &error_details_,
&details_, std::move(callback));
ASSERT_EQ(QUIC_FAILURE, status);
@@ -270,7 +270,7 @@ TEST_F(ProofVerifierChromiumTest, InvalidSCTList) {
std::unique_ptr<DummyProofVerifierCallback> callback(
new DummyProofVerifierCallback);
QuicAsyncStatus status = proof_verifier.VerifyProof(
- kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_,
+ kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, "", certs_,
ct::GetSCTListWithInvalidSCT(), "", verify_context_.get(),
&error_details_, &details_, std::move(callback));
ASSERT_EQ(QUIC_FAILURE, status);
@@ -288,7 +288,7 @@ TEST_F(ProofVerifierChromiumTest, FailsIfSignatureFails) {
std::unique_ptr<DummyProofVerifierCallback> callback(
new DummyProofVerifierCallback);
QuicAsyncStatus status = proof_verifier.VerifyProof(
- kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_, "",
+ kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, "", certs_, "",
kTestConfig, verify_context_.get(), &error_details_, &details_,
std::move(callback));
ASSERT_EQ(QUIC_FAILURE, status);
@@ -318,7 +318,7 @@ TEST_F(ProofVerifierChromiumTest, PreservesEVIfAllowed) {
std::unique_ptr<DummyProofVerifierCallback> callback(
new DummyProofVerifierCallback);
QuicAsyncStatus status = proof_verifier.VerifyProof(
- kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_, "",
+ kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, "", certs_, "",
GetTestSignature(), verify_context_.get(), &error_details_, &details_,
std::move(callback));
ASSERT_EQ(QUIC_SUCCESS, status);
@@ -354,7 +354,7 @@ TEST_F(ProofVerifierChromiumTest, StripsEVIfNotAllowed) {
std::unique_ptr<DummyProofVerifierCallback> callback(
new DummyProofVerifierCallback);
QuicAsyncStatus status = proof_verifier.VerifyProof(
- kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_, "",
+ kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, "", certs_, "",
GetTestSignature(), verify_context_.get(), &error_details_, &details_,
std::move(callback));
ASSERT_EQ(QUIC_SUCCESS, status);
@@ -389,7 +389,7 @@ TEST_F(ProofVerifierChromiumTest, IgnoresPolicyEnforcerIfNotEV) {
std::unique_ptr<DummyProofVerifierCallback> callback(
new DummyProofVerifierCallback);
QuicAsyncStatus status = proof_verifier.VerifyProof(
- kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_, "",
+ kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, "", certs_, "",
GetTestSignature(), verify_context_.get(), &error_details_, &details_,
std::move(callback));
ASSERT_EQ(QUIC_SUCCESS, status);
@@ -434,7 +434,7 @@ TEST_F(ProofVerifierChromiumTest, PKPEnforced) {
std::unique_ptr<DummyProofVerifierCallback> callback(
new DummyProofVerifierCallback);
QuicAsyncStatus status = proof_verifier.VerifyProof(
- kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_, "",
+ kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, "", certs_, "",
GetTestSignature(), verify_context_.get(), &error_details_, &details_,
std::move(callback));
ASSERT_EQ(QUIC_FAILURE, status);
@@ -475,7 +475,7 @@ TEST_F(ProofVerifierChromiumTest, PKPBypassFlagSet) {
std::unique_ptr<DummyProofVerifierCallback> callback(
new DummyProofVerifierCallback);
QuicAsyncStatus status = proof_verifier.VerifyProof(
- kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_, "",
+ kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, "", certs_, "",
GetTestSignature(), verify_context_.get(), &error_details_, &details_,
std::move(callback));
ASSERT_EQ(QUIC_SUCCESS, status);
@@ -521,7 +521,7 @@ TEST_F(ProofVerifierChromiumTest, CTIsRequired) {
std::unique_ptr<DummyProofVerifierCallback> callback(
new DummyProofVerifierCallback);
QuicAsyncStatus status = proof_verifier.VerifyProof(
- kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_, "",
+ kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, "", certs_, "",
GetTestSignature(), verify_context_.get(), &error_details_, &details_,
std::move(callback));
ASSERT_EQ(QUIC_FAILURE, status);
@@ -573,7 +573,7 @@ TEST_F(ProofVerifierChromiumTest, PKPAndCTBothTested) {
std::unique_ptr<DummyProofVerifierCallback> callback(
new DummyProofVerifierCallback);
QuicAsyncStatus status = proof_verifier.VerifyProof(
- kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_, "",
+ kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, "", certs_, "",
GetTestSignature(), verify_context_.get(), &error_details_, &details_,
std::move(callback));
ASSERT_EQ(QUIC_FAILURE, status);
« no previous file with comments | « net/quic/crypto/crypto_server_test.cc ('k') | net/quic/crypto/quic_crypto_client_config.cc » ('j') | net/tools/quic/quic_dispatcher.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698