Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2176313002: DevTools: disable "lineWiseCopyCut" CodeMirror option. (Closed)

Created:
4 years, 5 months ago by lushnikov
Modified:
4 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: disable "lineWiseCopyCut" CodeMirror option. This will disable the custom handling of Ctrl-X shortuct in the Edit-As-HTML field. BUG=470435 R=dgozman Committed: https://crrev.com/9a90013c1aed118e30006642425262503aa8b54f Cr-Commit-Position: refs/heads/master@{#407656}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorUtils.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
lushnikov
please, take a look
4 years, 5 months ago (2016-07-25 19:39:31 UTC) #1
dgozman
lgtm
4 years, 5 months ago (2016-07-25 22:45:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176313002/1
4 years, 5 months ago (2016-07-26 00:36:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-26 00:43:44 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-26 00:47:06 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a90013c1aed118e30006642425262503aa8b54f
Cr-Commit-Position: refs/heads/master@{#407656}

Powered by Google App Engine
This is Rietveld 408576698