Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2176293002: exo: Convert widget bounds to screen coordinates (Closed)

Created:
4 years, 4 months ago by Dominik Laskowski
Modified:
4 years, 4 months ago
Reviewers:
reveman, oshima
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Convert widget bounds to screen coordinates Since widget bounds were updated using coordinates relative to the root window, windows on secondary displays would snap back to the primary display after resizing. BUG=631136 TEST=Drag weston-terminal to secondary display and resize. TEST=ARC apps can still be dragged and maximized. Committed: https://crrev.com/51b855c765c5da89dad5ee3af9b0e138f7b75d08 Cr-Commit-Position: refs/heads/master@{#407646}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M components/exo/shell_surface.cc View 4 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Dominik Laskowski
4 years, 4 months ago (2016-07-25 19:14:15 UTC) #4
reveman
Doesn't this break when the root window is transformed? For example when using non-default resolution.
4 years, 4 months ago (2016-07-25 20:19:18 UTC) #7
Dominik Laskowski
On 2016/07/25 20:19:18, reveman wrote: > Doesn't this break when the root window is transformed? ...
4 years, 4 months ago (2016-07-25 22:35:46 UTC) #8
reveman
lgtm
4 years, 4 months ago (2016-07-25 23:09:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176293002/1
4 years, 4 months ago (2016-07-26 00:10:33 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 00:15:08 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 00:19:38 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51b855c765c5da89dad5ee3af9b0e138f7b75d08
Cr-Commit-Position: refs/heads/master@{#407646}

Powered by Google App Engine
This is Rietveld 408576698