[DevTools] Remove V8Debugger::logToConsole method

[DevTools] Remove V8Debugger::logToConsole method

BUG=631162
R=dgozman@chromium.org

Committed: https://crrev.com/46967dcd1886e00e442f31b61691fd55394e76cf
Cr-Commit-Position: refs/heads/master@{#407661}

[kozy, 2016-07-25 18:27:33]

Dmitry, please take a look!

[dgozman, 2016-07-25 18:35:37]

https://codereview.chromium.org/2176283002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp (right):

https://codereview.chromium.org/2176283002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp:246:
v8::MaybeLocal<v8::Value> compileAndRunInternalScript(v8::Isolate* isolate,
v8::Local<v8::Context> context, v8::Local<v8::String> code)
Why don't we use V8ScriptRunner?

https://codereview.chromium.org/2176283002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp:263: bool success =
compileAndRunInternalScript(m_isolate, m_isolate->GetCurrentContext(),
v8String(m_isolate, "(function(arg) { console.log(arg);
})")).ToLocal(&logFunctionValue) && logFunctionValue->IsFunction();
We used to log type and event object, now we log only single arg.

[kozy, 2016-07-25 18:48:45]

please take a look

https://codereview.chromium.org/2176283002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp (right):

https://codereview.chromium.org/2176283002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp:246:
v8::MaybeLocal<v8::Value> compileAndRunInternalScript(v8::Isolate* isolate,
v8::Local<v8::Context> context, v8::Local<v8::String> code)
On 2016/07/25 18:35:37, dgozman wrote:
> Why don't we use V8ScriptRunner?

I'd like to remove usage of isInternalScript flag outside of v8_inspector and
debuggers, so I'll replace V8ScriptRunner::compileAndRunInternalScript with
another method that doesn't pass isInternalScript flag.

https://codereview.chromium.org/2176283002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp:263: bool success =
compileAndRunInternalScript(m_isolate, m_isolate->GetCurrentContext(),
v8String(m_isolate, "(function(arg) { console.log(arg);
})")).ToLocal(&logFunctionValue) && logFunctionValue->IsFunction();
On 2016/07/25 18:35:37, dgozman wrote:
> We used to log type and event object, now we log only single arg.

Done.

[dgozman, 2016-07-25 19:05:51]

https://codereview.chromium.org/2176283002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp (right):

https://codereview.chromium.org/2176283002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp:259:
v8::Local<v8::Function> ThreadDebugger::eventLogFunction()
Let's not store it, but compile every time.

https://codereview.chromium.org/2176283002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp:263: bool success =
compileAndRunInternalScript(m_isolate, m_isolate->GetCurrentContext(),
v8String(m_isolate, "(function(e) { console.log(e.type, e);
})")).ToLocal(&logFunctionValue) && logFunctionValue->IsFunction();
As discussed offline, use V8ScriptRunner here.

[kozy, 2016-07-25 19:12:53]

Description was changed from

==========
[DevTools] Remove V8Debugger::logToConsole method

BUG=none
R=dgozman@chromium.org
==========

to

==========
[DevTools] Remove V8Debugger::logToConsole method

BUG=631162
R=dgozman@chromium.org
==========

[kozy, 2016-07-25 19:13:14]

all done! please take a look!

https://codereview.chromium.org/2176283002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp (right):

https://codereview.chromium.org/2176283002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp:259:
v8::Local<v8::Function> ThreadDebugger::eventLogFunction()
On 2016/07/25 19:05:51, dgozman wrote:
> Let's not store it, but compile every time.

Done.

https://codereview.chromium.org/2176283002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp:263: bool success =
compileAndRunInternalScript(m_isolate, m_isolate->GetCurrentContext(),
v8String(m_isolate, "(function(e) { console.log(e.type, e);
})")).ToLocal(&logFunctionValue) && logFunctionValue->IsFunction();
On 2016/07/25 19:05:51, dgozman wrote:
> As discussed offline, use V8ScriptRunner here.

Done.

[kozy, 2016-07-25 20:43:05]

please take a look!

[dgozman, 2016-07-25 22:33:33]

Thanks, Aleksey! lgtm

[kozy, 2016-07-25 23:11:11]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-07-25 23:11:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 00:52:59]

Description was changed from

==========
[DevTools] Remove V8Debugger::logToConsole method

BUG=631162
R=dgozman@chromium.org
==========

to

==========
[DevTools] Remove V8Debugger::logToConsole method

BUG=631162
R=dgozman@chromium.org
==========

[commit-bot: I haz the power, 2016-07-26 00:53:00]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-26 00:55:00]

Description was changed from

==========
[DevTools] Remove V8Debugger::logToConsole method

BUG=631162
R=dgozman@chromium.org
==========

to

==========
[DevTools] Remove V8Debugger::logToConsole method

BUG=631162
R=dgozman@chromium.org

Committed: https://crrev.com/46967dcd1886e00e442f31b61691fd55394e76cf
Cr-Commit-Position: refs/heads/master@{#407661}
==========

[commit-bot: I haz the power, 2016-07-26 00:55:02]

Patchset 5 (id:??) landed as
https://crrev.com/46967dcd1886e00e442f31b61691fd55394e76cf
Cr-Commit-Position: refs/heads/master@{#407661}