Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: net/quic/quic_crypto_server_stream_test.cc

Issue 2176273003: Deprecate FLAGS_quic_default_immediate_forward_secure. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@128225749
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_crypto_server_stream.cc ('k') | net/quic/quic_flags.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_crypto_server_stream_test.cc
diff --git a/net/quic/quic_crypto_server_stream_test.cc b/net/quic/quic_crypto_server_stream_test.cc
index 136a18c900cb4a0ab80308e9780914fff435466c..dd7e03c9921430f57860cd3429290d71225e0b31 100644
--- a/net/quic/quic_crypto_server_stream_test.cc
+++ b/net/quic/quic_crypto_server_stream_test.cc
@@ -225,30 +225,6 @@ TEST_P(QuicCryptoServerStreamTest, ConnectedAfterCHLO) {
EXPECT_TRUE(server_stream()->handshake_confirmed());
}
-TEST_P(QuicCryptoServerStreamTest, InitialEncryptionAfterCHLO) {
- Initialize();
- InitializeFakeClient(/* supports_stateless_rejects= */ false);
-
- // Do a first handshake in order to prime the client config with the server's
- // information.
- AdvanceHandshakeWithFakeClient();
- EXPECT_FALSE(server_stream()->encryption_established());
- EXPECT_FALSE(server_stream()->handshake_confirmed());
-
- // Now do another handshake, with the blocking SHLO connection option.
- InitializeServer();
- InitializeFakeClient(/* supports_stateless_rejects= */ false);
- if (FLAGS_quic_default_immediate_forward_secure) {
- client_session_->config()->SetConnectionOptionsToSend({kIPFS});
- }
-
- AdvanceHandshakeWithFakeClient();
- EXPECT_TRUE(server_stream()->encryption_established());
- EXPECT_TRUE(server_stream()->handshake_confirmed());
- EXPECT_EQ(ENCRYPTION_INITIAL,
- server_session_->connection()->encryption_level());
-}
-
TEST_P(QuicCryptoServerStreamTest, ForwardSecureAfterCHLO) {
Initialize();
InitializeFakeClient(/* supports_stateless_rejects= */ false);
@@ -262,9 +238,6 @@ TEST_P(QuicCryptoServerStreamTest, ForwardSecureAfterCHLO) {
// Now do another handshake, with the blocking SHLO connection option.
InitializeServer();
InitializeFakeClient(/* supports_stateless_rejects= */ false);
- if (!FLAGS_quic_default_immediate_forward_secure) {
- client_session_->config()->SetConnectionOptionsToSend({kIPFS});
- }
AdvanceHandshakeWithFakeClient();
EXPECT_TRUE(server_stream()->encryption_established());
« no previous file with comments | « net/quic/quic_crypto_server_stream.cc ('k') | net/quic/quic_flags.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698