Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: tool/input_sdk/private/debugger.dart

Issue 2176233002: Library children object fix (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Library children fixing Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « lib/runtime/dart_sdk.js ('k') | tool/sdk_expected_errors.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart._debugger; 5 library dart._debugger;
6 6
7 import 'dart:_foreign_helper' show JS; 7 import 'dart:_foreign_helper' show JS;
8 import 'dart:_runtime' as dart; 8 import 'dart:_runtime' as dart;
9 import 'dart:core'; 9 import 'dart:core';
10 import 'dart:collection'; 10 import 'dart:collection';
(...skipping 559 matching lines...) Expand 10 before | Expand all | Expand 10 after
570 } else if (value is Type) { 570 } else if (value is Type) {
571 var typeName = getTypeName(value); 571 var typeName = getTypeName(value);
572 // Generic class names are generated with a $ at the end, so the 572 // Generic class names are generated with a $ at the end, so the
573 // corresponding non-generic class can be identified by adding $. 573 // corresponding non-generic class can be identified by adding $.
574 if ('$name\$' == genericName) { 574 if ('$name\$' == genericName) {
575 typeName = '$typeName<$genericArguments>'; 575 typeName = '$typeName<$genericArguments>';
576 } 576 }
577 children.add(new NameValuePair( 577 children.add(new NameValuePair(
578 name: typeName, value: new ClassMetadata(value, name: typeName))); 578 name: typeName, value: new ClassMetadata(value, name: typeName)));
579 } else { 579 } else {
580 children.add( 580 children.add(new NameValuePair(name: name, value: value));
Alan Knight 2016/07/25 19:51:38 This code is complicated enough it might be worth
bmilligan 2016/07/25 20:23:54 Done.
581 new NameValuePair(name: name, value: new ClassMetadata(value)));
582 } 581 }
583 } 582 }
584 } 583 }
585 return children.toList(); 584 return children.toList();
586 } 585 }
587 } 586 }
588 587
589 /// Formatter for Dart Function objects. 588 /// Formatter for Dart Function objects.
590 /// Dart functions happen to be regular JavaScript Function objects but 589 /// Dart functions happen to be regular JavaScript Function objects but
591 /// we can distinguish them based on whether they have been tagged with 590 /// we can distinguish them based on whether they have been tagged with
(...skipping 227 matching lines...) Expand 10 before | Expand all | Expand 10 after
819 818
820 List<NameValuePair> children(object) => object.children(); 819 List<NameValuePair> children(object) => object.children();
821 } 820 }
822 821
823 /// This entry point is automatically invoked by the code generated by 822 /// This entry point is automatically invoked by the code generated by
824 /// Dart Dev Compiler 823 /// Dart Dev Compiler
825 registerDevtoolsFormatter() { 824 registerDevtoolsFormatter() {
826 var formatters = [_devtoolsFormatter]; 825 var formatters = [_devtoolsFormatter];
827 JS('', 'dart.global.devtoolsFormatters = #', formatters); 826 JS('', 'dart.global.devtoolsFormatters = #', formatters);
828 } 827 }
OLDNEW
« no previous file with comments | « lib/runtime/dart_sdk.js ('k') | tool/sdk_expected_errors.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698