Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2176223002: Call update-w3c-test-expectations in deps_updater.py (Closed)

Created:
4 years, 5 months ago by dcampb
Modified:
4 years, 4 months ago
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call update-w3c-test-expectations in deps_updater.py BUG=629275, 625253 Committed: https://crrev.com/a3e332718498531c05a7ac348fe790fb7e7b026b Cr-Commit-Position: refs/heads/master@{#407995}

Patch Set 1 #

Total comments: 10

Patch Set 2 : Change host object called in update-w3c-deps and use builderlist for try-bots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -12 lines) Patch
M third_party/WebKit/Tools/Scripts/update-w3c-deps View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py View 1 2 chunks +20 lines, -9 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
dcampb
https://codereview.chromium.org/2176223002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py (left): https://codereview.chromium.org/2176223002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py#oldcode68 third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:68: self.check_run(['git', 'cl', 'upload', '-f']) note, this flag uploads a ...
4 years, 5 months ago (2016-07-25 17:09:28 UTC) #2
qyearsley
https://codereview.chromium.org/2176223002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py (right): https://codereview.chromium.org/2176223002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py#newcode73 third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:73: self.run(['git', 'cl', 'try', '-b', 'win_chromium_rel_ng']) As mentioned in person, ...
4 years, 5 months ago (2016-07-25 21:57:34 UTC) #4
dcampb
https://codereview.chromium.org/2176223002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py (right): https://codereview.chromium.org/2176223002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py#newcode73 third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:73: self.run(['git', 'cl', 'try', '-b', 'win_chromium_rel_ng']) On 2016/07/25 at 21:57:34, ...
4 years, 4 months ago (2016-07-26 21:18:10 UTC) #5
Dirk Pranke
lgtm
4 years, 4 months ago (2016-07-26 23:26:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176223002/20001
4 years, 4 months ago (2016-07-26 23:41:36 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-27 00:54:53 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 00:58:19 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a3e332718498531c05a7ac348fe790fb7e7b026b
Cr-Commit-Position: refs/heads/master@{#407995}

Powered by Google App Engine
This is Rietveld 408576698