Call update-w3c-test-expectations in deps_updater.py

Call update-w3c-test-expectations in deps_updater.py

BUG=629275, 625253
Committed: https://crrev.com/a3e332718498531c05a7ac348fe790fb7e7b026b
Cr-Commit-Position: refs/heads/master@{#407995}

[dcampb, 2016-07-25 17:09:27]

dcampb@google.com changed reviewers:
+ dpranke@chromium.org, qyearsley@chromium.org, raikiri@google.com

[dcampb, 2016-07-25 17:09:28]

https://codereview.chromium.org/2176223002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py (left):

https://codereview.chromium.org/2176223002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:68:
self.check_run(['git', 'cl', 'upload', '-f'])
note,

this flag uploads a cl even if no new test were imported. However, some
dependencies could be removed from the update. Is that okay?

https://codereview.chromium.org/2176223002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py (right):

https://codereview.chromium.org/2176223002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:88:
self.run([self.host.executable, script_path])
This will add lines to Test Expectations IF the test does not already exist in
Test Expectations file. 
Also, It does not only add test files that were imported, but also test that
failed during try-jobs. 
What do you all think about this?

[dcampb, 2016-07-25 18:07:50]

Description was changed from

==========
Refactored auto update flag in deps_updater.py


BUG=629275, 625253
==========

to

==========
Call update-w3c-test-expectations in deps_updater.py

BUG=629275, 625253
==========

[qyearsley, 2016-07-25 21:57:34]

https://codereview.chromium.org/2176223002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py (right):

https://codereview.chromium.org/2176223002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:73:
self.run(['git', 'cl', 'try', '-b', 'win_chromium_rel_ng'])
As mentioned in person, we will want to get the list of try bots from a
BuilderList object.

https://codereview.chromium.org/2176223002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:88:
self.run([self.host.executable, script_path])
On 2016/07/25 at 17:09:27, dcampb wrote:
> This will add lines to Test Expectations IF the test does not already exist in
Test Expectations file. 
> Also, It does not only add test files that were imported, but also test that
failed during try-jobs. 
> What do you all think about this?

Seems like it should only ever add tests that were imported.

Additionally, for testharness.js tests that fail (but not crash/timeout), I
believe in the future we probably always want to add the new -expected.txt
baseline files rather than adding lines to TestExpectations -- this could either
be done in update_w3c_test_expectations.py (using the downloaded results from
the try bots), or potentially this could be done by `webkit-patch
rebaseline-from-try-jobs.

https://codereview.chromium.org/2176223002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:89:
self.check_run(['git', 'commit', '-a', '-m', '\'Modified Test Expectations from
W3C_Test_AutoRoller\''])
W3C_Test_Autoroller -> W3C Test Auto-roller?

https://codereview.chromium.org/2176223002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:90:
self.check_run(['git', 'cl', 'upload', '-m', '\'Wrote lines to Test
Expectations\''])
Test Expectations -> TestExpectations

[dcampb, 2016-07-26 21:18:10]

https://codereview.chromium.org/2176223002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py (right):

https://codereview.chromium.org/2176223002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:73:
self.run(['git', 'cl', 'try', '-b', 'win_chromium_rel_ng'])
On 2016/07/25 at 21:57:34, qyearsley wrote:
> As mentioned in person, we will want to get the list of try bots from a
BuilderList object.

done

https://codereview.chromium.org/2176223002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:88:
self.run([self.host.executable, script_path])
On 2016/07/25 at 21:57:34, qyearsley wrote:
> On 2016/07/25 at 17:09:27, dcampb wrote:
> > This will add lines to Test Expectations IF the test does not already exist
in Test Expectations file. 
> > Also, It does not only add test files that were imported, but also test that
failed during try-jobs. 
> > What do you all think about this?
> 
> Seems like it should only ever add tests that were imported.
> 
> Additionally, for testharness.js tests that fail (but not crash/timeout), I
believe in the future we probably always want to add the new -expected.txt
baseline files rather than adding lines to TestExpectations -- this could either
be done in update_w3c_test_expectations.py (using the downloaded results from
the try bots), or potentially this could be done by `webkit-patch
rebaseline-from-try-jobs.

Fixed only adding new imported test. See issue #:2183913002. 
As for the testharness.js test, I am still looking into that. Where
files/directory should I start to investigate in?

https://codereview.chromium.org/2176223002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:89:
self.check_run(['git', 'commit', '-a', '-m', '\'Modified Test Expectations from
W3C_Test_AutoRoller\''])
On 2016/07/25 at 21:57:34, qyearsley wrote:
> W3C_Test_Autoroller -> W3C Test Auto-roller?

done

https://codereview.chromium.org/2176223002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:90:
self.check_run(['git', 'cl', 'upload', '-m', '\'Wrote lines to Test
Expectations\''])
On 2016/07/25 at 21:57:34, qyearsley wrote:
> Test Expectations -> TestExpectations

done

[Dirk Pranke, 2016-07-26 23:26:27]

lgtm

[dcampb, 2016-07-26 23:40:55]

The CQ bit was checked by dcampb@google.com

[commit-bot: I haz the power, 2016-07-26 23:41:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 00:54:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-27 00:58:18]

Description was changed from

==========
Call update-w3c-test-expectations in deps_updater.py

BUG=629275, 625253
==========

to

==========
Call update-w3c-test-expectations in deps_updater.py

BUG=629275, 625253

Committed: https://crrev.com/a3e332718498531c05a7ac348fe790fb7e7b026b
Cr-Commit-Position: refs/heads/master@{#407995}
==========

[commit-bot: I haz the power, 2016-07-27 00:58:19]

Patchset 2 (id:??) landed as
https://crrev.com/a3e332718498531c05a7ac348fe790fb7e7b026b
Cr-Commit-Position: refs/heads/master@{#407995}