Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 2176203004: Remove unused method declaration - IsLikelyAutoNavigation. (Closed)

Created:
4 years, 4 months ago by nasko
Modified:
4 years, 4 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused method declaration - IsLikelyAutoNavigation. Just dead code cleanup. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/c1128eafc524b6f61c557e8c3f1c27e9baf27888 Cr-Commit-Position: refs/heads/master@{#407643}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M content/browser/frame_host/navigation_controller_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
nasko
Hey Charlie, Can you take a look at this CL? It removes a bit of ...
4 years, 4 months ago (2016-07-25 21:58:38 UTC) #5
Charlie Reis
Nice, thanks for the cleanup. LGTM!
4 years, 4 months ago (2016-07-25 22:27:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176203004/1
4 years, 4 months ago (2016-07-26 00:04:05 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 00:09:00 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 00:12:45 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1128eafc524b6f61c557e8c3f1c27e9baf27888
Cr-Commit-Position: refs/heads/master@{#407643}

Powered by Google App Engine
This is Rietveld 408576698