Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2176203002: Revert of [Chromedriver] Re-enable ImplicitWaitTest.testShouldImplicitlyWaitForASingleElement (Closed)

Created:
4 years, 5 months ago by gmanikpure
Modified:
4 years, 5 months ago
Reviewers:
samuong
CC:
chromium-reviews, samuong+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Chromedriver] Re-enable ImplicitWaitTest.testShouldImplicitlyWaitForASingleElement on ChromePublic (patchset #1 id:1 of https://codereview.chromium.org/2175893002/ ) Reason for revert: Test was re-enabled because the bots were running against old chromedriver build having name "rNone" . But the test is still failing on correct Head builds that confirms it's a real bug & hence needs to be disabled again. Original issue's description: > [Chromedriver] Re-enable ImplicitWaitTest.testShouldImplicitlyWaitForASingleElement on ChromePublic > > BUG=chromedriver:998 > > Committed: https://crrev.com/970ac6812ff04c3f44ae770b612b093b6feb5d80 > Cr-Commit-Position: refs/heads/master@{#407234} TBR=samuong@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromedriver:998 Committed: https://crrev.com/807cac8b6aa4d4b29121e1780297497d19aaeb4d Cr-Commit-Position: refs/heads/master@{#407493}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/test/chromedriver/test/test_expectations View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
gmanikpure
Created Revert of [Chromedriver] Re-enable ImplicitWaitTest.testShouldImplicitlyWaitForASingleElement on ChromePublic
4 years, 5 months ago (2016-07-25 15:57:33 UTC) #2
samuong
lgtm lgtm
4 years, 5 months ago (2016-07-25 16:12:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176203002/1
4 years, 5 months ago (2016-07-25 16:12:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 16:51:52 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 16:54:41 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/807cac8b6aa4d4b29121e1780297497d19aaeb4d
Cr-Commit-Position: refs/heads/master@{#407493}

Powered by Google App Engine
This is Rietveld 408576698