Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Issue 2176193002: respect kFast_SrcRectConstraint by allowing shader access to entire bitmap (Closed)

Created:
4 years, 5 months ago by reed1
Modified:
4 years, 5 months ago
Reviewers:
xidachen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

respect kFast_SrcRectConstraint by allowing shader access to entire bitmap BUG=355305 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2176193002 Committed: https://skia.googlesource.com/skia/+/27efa2371e27d5306f214e4b0bda60848fd49c02

Patch Set 1 #

Patch Set 2 : rebased w/ new gm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M src/core/SkBitmapDevice.cpp View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
xidachen
On 2016/07/25 15:51:13, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 5 months ago (2016-07-25 18:51:08 UTC) #7
reed1
sg -- I'll wait for your approval on this CL
4 years, 5 months ago (2016-07-25 18:57:08 UTC) #9
xidachen
lgtm The other CL has committed, so this one should not break any Webkit tests. ...
4 years, 5 months ago (2016-07-26 01:57:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176193002/20001
4 years, 5 months ago (2016-07-26 02:09:19 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-26 02:10:13 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/27efa2371e27d5306f214e4b0bda60848fd49c02

Powered by Google App Engine
This is Rietveld 408576698