Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2176183008: Simple Cache: validate lengths before allocations. (Closed)

Created:
4 years, 4 months ago by gavinp
Modified:
4 years, 4 months ago
Reviewers:
Julia Tuttle
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Simple Cache: validate lengths before allocations. This bug was most unfortunate. A corrupt entry could cause Chrome to crash when opening it, without removing the entry. Not a good loop to be in. Now we are much more careful with casts around the data coming from disk to confirm sanity before proceeding. R=juliatuttle@chromium.org BUG=541720 Review-Url: https://codereview.chromium.org/2086053003 Cr-Commit-Position: refs/heads/master@{#408134} (cherry picked from commit bf840cc6c21c5a5b6e95d120e5493e0a7eb61498) Committed: https://chromium.googlesource.com/chromium/src/+/4cf894119c534fbf3fce69ef3d684cfc16b59fbf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -12 lines) Patch
M net/disk_cache/entry_unittest.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M net/disk_cache/simple/simple_synchronous_entry.h View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/simple/simple_synchronous_entry.cc View 4 chunks +14 lines, -11 lines 0 comments Download
M net/disk_cache/simple/simple_test_util.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/disk_cache/simple/simple_test_util.cc View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
gavinp
4 years, 4 months ago (2016-07-27 17:58:47 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4cf894119c534fbf3fce69ef3d684cfc16b59fbf (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698