Revert of Enable Expect-Staple in SSLClientSocket.

Revert of Enable Expect-Staple in SSLClientSocket. (patchset #3 id:40001 of https://codereview.chromium.org/2155753002/ )

Reason for revert:
The newly added test HTTPSOCSPTest.ExpectStapleReportNotSentOnValid fails on the Android bot:
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20ARMv6%20Builder/builds/2675

C  165.045s Main  Detailed Logs
C  165.045s Main  ********************************************************************************
C  165.063s Main  [FAIL] HTTPSOCSPTest.ExpectStapleReportNotSentOnValid:
C  165.063s Main  [ RUN      ] HTTPSOCSPTest.ExpectStapleReportNotSentOnValid
C  165.063s Main  [WARNING:embedded_test_server.cc(193)] Request not handled. Returning 404: /
C  165.063s Main  ../../net/url_request/url_request_unittest.cc:9342: Failure
C  165.063s Main  Value of: mock_report_sender.latest_report().empty()
C  165.063s Main    Actual: false
C  165.064s Main  Expected: true
C  165.064s Main  ../../net/url_request/url_request_unittest.cc:9343: Failure
C  165.064s Main  Value of: mock_report_sender.latest_report_uri()
C  165.064s Main    Actual: https://report.badssl.com/expect-staple
C  165.064s Main  Expected: GURL()
C  165.064s Main  Which is:
C  165.064s Main  [  FAILED  ] HTTPSOCSPTest.ExpectStapleReportNotSentOnValid (65 ms)

Original issue's description:
> Enable Expect-Staple in SSLClientSocket.
>
> In TransportSecurityState, set |enable_static_expect_staple_|
> to true by default. Update SSLClientSocket to call
> TransportSecurityState::ProcessExpectStaple.
>
> In ssl_client_socket_impl.cc, this also removes the if
> (|signed_certificate_timestamps_enabled_) check around
> extracting the OCSP response and setting the
> UMA_HISTOGRAM_BOOLEAN("Net.OCSPResponseStapled"). Since
> SCTs are always enabled, this if statement was a noop.
>
> This does not enable Expect-Staple for QUIC. See
> https://crbug.com/631101
>
> BUG=598021
>
> Committed: https://crrev.com/3c0e49240847ea54265e17c7a8a1ecf73daeaeee
> Cr-Commit-Position: refs/heads/master@{#407575}

TBR=svaldez@chromium.org,rsleevi@chromium.org,estark@chromium.org,dadrian@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=598021
Committed: https://crrev.com/5b3cfa2861a8c2d452111225fb5f95c7b561b50c
Cr-Commit-Position: refs/heads/master@{#407606}

[Mark P, 2016-07-25 21:56:34]

The CQ bit was checked by mpearson@chromium.org

[Mark P, 2016-07-25 21:56:34]

Created Revert of Enable Expect-Staple in SSLClientSocket.

[commit-bot: I haz the power, 2016-07-25 21:57:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 21:58:27]

Description was changed from

==========
Revert of Enable Expect-Staple in SSLClientSocket. (patchset #3 id:40001 of
https://codereview.chromium.org/2155753002/ )

Reason for revert:
The newly added test HTTPSOCSPTest.ExpectStapleReportNotSentOnValid fails on the
Android bot:
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20ARM...


C  165.045s Main  Detailed Logs
C  165.045s Main 
********************************************************************************
C  165.063s Main  [FAIL] HTTPSOCSPTest.ExpectStapleReportNotSentOnValid:
C  165.063s Main  [ RUN      ] HTTPSOCSPTest.ExpectStapleReportNotSentOnValid
C  165.063s Main  [WARNING:embedded_test_server.cc(193)] Request not handled.
Returning 404: /
C  165.063s Main  ../../net/url_request/url_request_unittest.cc:9342: Failure
C  165.063s Main  Value of: mock_report_sender.latest_report().empty()
C  165.063s Main    Actual: false
C  165.064s Main  Expected: true
C  165.064s Main  ../../net/url_request/url_request_unittest.cc:9343: Failure
C  165.064s Main  Value of: mock_report_sender.latest_report_uri()
C  165.064s Main    Actual: https://report.badssl.com/expect-staple
C  165.064s Main  Expected: GURL()
C  165.064s Main  Which is: 
C  165.064s Main  [  FAILED  ] HTTPSOCSPTest.ExpectStapleReportNotSentOnValid
(65 ms)

Original issue's description:
> Enable Expect-Staple in SSLClientSocket.
> 
> In TransportSecurityState, set |enable_static_expect_staple_|
> to true by default. Update SSLClientSocket to call
> TransportSecurityState::ProcessExpectStaple.
> 
> In ssl_client_socket_impl.cc, this also removes the if
> (|signed_certificate_timestamps_enabled_) check around
> extracting the OCSP response and setting the
> UMA_HISTOGRAM_BOOLEAN("Net.OCSPResponseStapled"). Since
> SCTs are always enabled, this if statement was a noop.
> 
> This does not enable Expect-Staple for QUIC. See
> https://crbug.com/631101
> 
> BUG=598021
> 
> Committed: https://crrev.com/3c0e49240847ea54265e17c7a8a1ecf73daeaeee
> Cr-Commit-Position: refs/heads/master@{#407575}

TBR=svaldez@chromium.org,rsleevi@chromium.org,estark@chromium.org,dadrian@goo...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=598021
==========

to

==========
Revert of Enable Expect-Staple in SSLClientSocket. (patchset #3 id:40001 of
https://codereview.chromium.org/2155753002/ )

Reason for revert:
The newly added test HTTPSOCSPTest.ExpectStapleReportNotSentOnValid fails on the
Android bot:
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20ARM...


C  165.045s Main  Detailed Logs
C  165.045s Main 
********************************************************************************
C  165.063s Main  [FAIL] HTTPSOCSPTest.ExpectStapleReportNotSentOnValid:
C  165.063s Main  [ RUN      ] HTTPSOCSPTest.ExpectStapleReportNotSentOnValid
C  165.063s Main  [WARNING:embedded_test_server.cc(193)] Request not handled.
Returning 404: /
C  165.063s Main  ../../net/url_request/url_request_unittest.cc:9342: Failure
C  165.063s Main  Value of: mock_report_sender.latest_report().empty()
C  165.063s Main    Actual: false
C  165.064s Main  Expected: true
C  165.064s Main  ../../net/url_request/url_request_unittest.cc:9343: Failure
C  165.064s Main  Value of: mock_report_sender.latest_report_uri()
C  165.064s Main    Actual: https://report.badssl.com/expect-staple
C  165.064s Main  Expected: GURL()
C  165.064s Main  Which is: 
C  165.064s Main  [  FAILED  ] HTTPSOCSPTest.ExpectStapleReportNotSentOnValid
(65 ms)

Original issue's description:
> Enable Expect-Staple in SSLClientSocket.
> 
> In TransportSecurityState, set |enable_static_expect_staple_|
> to true by default. Update SSLClientSocket to call
> TransportSecurityState::ProcessExpectStaple.
> 
> In ssl_client_socket_impl.cc, this also removes the if
> (|signed_certificate_timestamps_enabled_) check around
> extracting the OCSP response and setting the
> UMA_HISTOGRAM_BOOLEAN("Net.OCSPResponseStapled"). Since
> SCTs are always enabled, this if statement was a noop.
> 
> This does not enable Expect-Staple for QUIC. See
> https://crbug.com/631101
> 
> BUG=598021
> 
> Committed: https://crrev.com/3c0e49240847ea54265e17c7a8a1ecf73daeaeee
> Cr-Commit-Position: refs/heads/master@{#407575}

TBR=svaldez@chromium.org,rsleevi@chromium.org,estark@chromium.org,dadrian@goo...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=598021
==========

[commit-bot: I haz the power, 2016-07-25 21:58:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-25 21:59:49]

Description was changed from

==========
Revert of Enable Expect-Staple in SSLClientSocket. (patchset #3 id:40001 of
https://codereview.chromium.org/2155753002/ )

Reason for revert:
The newly added test HTTPSOCSPTest.ExpectStapleReportNotSentOnValid fails on the
Android bot:
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20ARM...


C  165.045s Main  Detailed Logs
C  165.045s Main 
********************************************************************************
C  165.063s Main  [FAIL] HTTPSOCSPTest.ExpectStapleReportNotSentOnValid:
C  165.063s Main  [ RUN      ] HTTPSOCSPTest.ExpectStapleReportNotSentOnValid
C  165.063s Main  [WARNING:embedded_test_server.cc(193)] Request not handled.
Returning 404: /
C  165.063s Main  ../../net/url_request/url_request_unittest.cc:9342: Failure
C  165.063s Main  Value of: mock_report_sender.latest_report().empty()
C  165.063s Main    Actual: false
C  165.064s Main  Expected: true
C  165.064s Main  ../../net/url_request/url_request_unittest.cc:9343: Failure
C  165.064s Main  Value of: mock_report_sender.latest_report_uri()
C  165.064s Main    Actual: https://report.badssl.com/expect-staple
C  165.064s Main  Expected: GURL()
C  165.064s Main  Which is: 
C  165.064s Main  [  FAILED  ] HTTPSOCSPTest.ExpectStapleReportNotSentOnValid
(65 ms)

Original issue's description:
> Enable Expect-Staple in SSLClientSocket.
> 
> In TransportSecurityState, set |enable_static_expect_staple_|
> to true by default. Update SSLClientSocket to call
> TransportSecurityState::ProcessExpectStaple.
> 
> In ssl_client_socket_impl.cc, this also removes the if
> (|signed_certificate_timestamps_enabled_) check around
> extracting the OCSP response and setting the
> UMA_HISTOGRAM_BOOLEAN("Net.OCSPResponseStapled"). Since
> SCTs are always enabled, this if statement was a noop.
> 
> This does not enable Expect-Staple for QUIC. See
> https://crbug.com/631101
> 
> BUG=598021
> 
> Committed: https://crrev.com/3c0e49240847ea54265e17c7a8a1ecf73daeaeee
> Cr-Commit-Position: refs/heads/master@{#407575}

TBR=svaldez@chromium.org,rsleevi@chromium.org,estark@chromium.org,dadrian@goo...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=598021
==========

to

==========
Revert of Enable Expect-Staple in SSLClientSocket. (patchset #3 id:40001 of
https://codereview.chromium.org/2155753002/ )

Reason for revert:
The newly added test HTTPSOCSPTest.ExpectStapleReportNotSentOnValid fails on the
Android bot:
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20ARM...

C  165.045s Main  Detailed Logs
C  165.045s Main 
********************************************************************************
C  165.063s Main  [FAIL] HTTPSOCSPTest.ExpectStapleReportNotSentOnValid:
C  165.063s Main  [ RUN      ] HTTPSOCSPTest.ExpectStapleReportNotSentOnValid
C  165.063s Main  [WARNING:embedded_test_server.cc(193)] Request not handled.
Returning 404: /
C  165.063s Main  ../../net/url_request/url_request_unittest.cc:9342: Failure
C  165.063s Main  Value of: mock_report_sender.latest_report().empty()
C  165.063s Main    Actual: false
C  165.064s Main  Expected: true
C  165.064s Main  ../../net/url_request/url_request_unittest.cc:9343: Failure
C  165.064s Main  Value of: mock_report_sender.latest_report_uri()
C  165.064s Main    Actual: https://report.badssl.com/expect-staple
C  165.064s Main  Expected: GURL()
C  165.064s Main  Which is:
C  165.064s Main  [  FAILED  ] HTTPSOCSPTest.ExpectStapleReportNotSentOnValid
(65 ms)

Original issue's description:
> Enable Expect-Staple in SSLClientSocket.
>
> In TransportSecurityState, set |enable_static_expect_staple_|
> to true by default. Update SSLClientSocket to call
> TransportSecurityState::ProcessExpectStaple.
>
> In ssl_client_socket_impl.cc, this also removes the if
> (|signed_certificate_timestamps_enabled_) check around
> extracting the OCSP response and setting the
> UMA_HISTOGRAM_BOOLEAN("Net.OCSPResponseStapled"). Since
> SCTs are always enabled, this if statement was a noop.
>
> This does not enable Expect-Staple for QUIC. See
> https://crbug.com/631101
>
> BUG=598021
>
> Committed: https://crrev.com/3c0e49240847ea54265e17c7a8a1ecf73daeaeee
> Cr-Commit-Position: refs/heads/master@{#407575}

TBR=svaldez@chromium.org,rsleevi@chromium.org,estark@chromium.org,dadrian@goo...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=598021

Committed: https://crrev.com/5b3cfa2861a8c2d452111225fb5f95c7b561b50c
Cr-Commit-Position: refs/heads/master@{#407606}
==========

[commit-bot: I haz the power, 2016-07-25 21:59:50]

Patchset 1 (id:??) landed as
https://crrev.com/5b3cfa2861a8c2d452111225fb5f95c7b561b50c
Cr-Commit-Position: refs/heads/master@{#407606}

[Mark P, 2016-07-25 22:25:51]

FYI, the original changelist that this change reverts also caused failures on
other bots:
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests/...
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/...

(It's just the Android bot was faster at alerting us to this issue.)

--mark

[Mark P, 2016-07-25 22:26:46]

On 2016/07/25 22:25:51, Mark P (no metrics til 7-26) wrote:
> FYI, the original changelist that this change reverts also caused failures on
> other bots:
>
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests/...
>
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/...
> 
> (It's just the Android bot was faster at alerting us to this issue.)
> 
> --mark

and
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C...

[Mark P, 2016-07-25 22:27:57]

On 2016/07/25 22:26:46, Mark P (no metrics til 7-26) wrote:
> On 2016/07/25 22:25:51, Mark P (no metrics til 7-26) wrote:
> > FYI, the original changelist that this change reverts also caused failures
on
> > other bots:
> >
>
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests/...
> >
>
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/...
> > 
> > (It's just the Android bot was faster at alerting us to this issue.)
> > 
> > --mark
> 
> and
>
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C...

and more.  I'm going to stop posting links here.